Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 10540131: Chrome Endure tests no longer unnecessarily check for Deep Memory Profiler platform support. (Closed)

Created:
8 years, 6 months ago by dennis_jeffrey
Modified:
8 years, 6 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh, Dai Mikurube (NOT FULLTIME), fmantek1
Visibility:
Public.

Description

Chrome Endure tests no longer unnecessarily check for Deep Memory Profiler platform support. Previously, Chrome Endure tests would check to ensure that the current platform is supported by the Deep Memory Profiler (i.e., is Linux) whether or not Deep Memory Profiling is enabled. This prevented the endurance tests from running on other platforms, even if not using the Deep Memory Profiler. This CL moves the supported platform check into a codepath that is only executed if the Deep Memory Profiler is requested. BUG=None TEST=None NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141782

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/test/functional/perf_endure.py View 2 chunks +3 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dennis_jeffrey
8 years, 6 months ago (2012-06-12 22:20:58 UTC) #1
Nirnimesh
LGTM
8 years, 6 months ago (2012-06-12 23:06:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dennisjeffrey@chromium.org/10540131/1
8 years, 6 months ago (2012-06-12 23:13:56 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 23:14:51 UTC) #4
Change committed as 141782

Powered by Google App Engine
This is Rietveld 408576698