Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5613)

Unified Diff: chrome/test/functional/perf_endure.py

Issue 10540131: Chrome Endure tests no longer unnecessarily check for Deep Memory Profiler platform support. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/perf_endure.py
diff --git a/chrome/test/functional/perf_endure.py b/chrome/test/functional/perf_endure.py
index 9ee5f0ed1a2e15aa8646f4f9d44816ed15cecd0c..36fd6fe76d890100bbbd12e98f882819e85d5e1d 100755
--- a/chrome/test/functional/perf_endure.py
+++ b/chrome/test/functional/perf_endure.py
@@ -69,6 +69,9 @@ class ChromeEndureBaseTest(perf.BasePerfTest):
'DEEP_MEMORY_PROFILE_INTERVAL', int, self._DEEP_MEMORY_PROFILE_INTERVAL)
if self._deep_memory_profile:
+ if not self.IsLinux():
+ raise NotSupportedEnvironmentError(
+ 'Deep Memory Profiler is not supported in this environment (OS).')
dir_prefix = 'endure.%s.' % datetime.today().strftime('%Y%m%d.%H%M%S')
self._deep_tempdir = tempfile.mkdtemp(prefix=dir_prefix)
os.environ['HEAPPROFILE'] = os.path.join(self._deep_tempdir, 'endure')
@@ -145,13 +148,7 @@ class ChromeEndureBaseTest(perf.BasePerfTest):
Returns:
A value converted from the environment variable with 'converter'.
-
- Raises:
- NotSupportedEnvironmentError if the environment (OS) is not supported.
"""
- if not self.IsLinux():
- raise NotSupportedEnvironmentError(
- 'Deep Memory Profiler is not supported in this environment (OS).')
return converter(os.environ.get(env_name, default))
def _WaitForDeepMemoryProfiler(self):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698