Issue 10540114: Issue 3528. Additional checks for 'case expressions'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10540114: Issue 3528. Additional checks for 'case expressions' (Closed)

Created:
8 years, 6 months ago by scheglov

Modified:
8 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 3528. Additional checks for 'case expressions' http://code.google.com/p/dart/issues/detail?id=3528 R=brianwilkerson@google.com BUG= TEST= Committed: https://code.google.com/p/dart/source/detail?r=8573

Patch Set 1 #

Total comments: 3

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -65 lines)			Patch
M	compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1 chunk	+53 lines, -4 lines	1 comment	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	samples/total/client/SYLKReader.dart	View	1 chunk	+4 lines, -8 lines	1 comment	Download
M	tests/co19/co19-compiler.status	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	tests/language/switch_test.dart	View	3 chunks	+1 line, -18 lines	1 comment	Download
D	tests/language/switch_this_test.dart	View	1 chunk	+0 lines, -28 lines	0 comments	Download
M	utils/tests/pub/pub.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

8 years, 6 months ago (2012-06-12 14:58:50 UTC) #2

LGTM

https://chromiumcodereview.appspot.com/10540114/diff/1/compiler/javatests/com...
File
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java
(right):

https://chromiumcodereview.appspot.com/10540114/diff/1/compiler/javatests/com...
compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java:199:
"  switch (v) {",
The first two switch statements are not necessary to the test, so I would remove
them, but it's your call.

https://chromiumcodereview.appspot.com/10540114/diff/1/samples/total/client/S...
File samples/total/client/SYLKReader.dart (right):

https://chromiumcodereview.appspot.com/10540114/diff/1/samples/total/client/S...
samples/total/client/SYLKReader.dart:1: // Copyright (c) 2011, the Dart project
authors.  Please see the AUTHORS file
nit: copyright year

https://chromiumcodereview.appspot.com/10540114/diff/1/tests/language/switch_...
File tests/language/switch_test.dart (right):

https://chromiumcodereview.appspot.com/10540114/diff/1/tests/language/switch_...
tests/language/switch_test.dart:1: // Copyright (c) 2011, the Dart project
authors.  Please see the AUTHORS file
nit: copyright year

Expand Messages | Collapse Messages