compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java - Issue 10540114: Issue 3528. Additional checks for 'case expressions'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java

Issue 10540114: Issue 3528. Additional checks for 'case expressions' (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java » ('j') | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java b/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java

index 303ee79c6e8dd9041d38e9f85284e7a083b9b433..b7c75512cb2803abcb1a729a92d0812dda9514f3 100644

--- a/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java

+++ b/compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java

@@ -25,6 +25,10 @@ public enum TypeErrorCode implements ErrorCode {

DEFAULT_CONSTRUCTOR_TYPES(

"Constructor '%s' in '%s' has parameters types (%s), doesn't match '%s' in '%s' with (%s)"),

DUPLICATE_NAMED_ARGUMENT("Named parameter argument already provided as positional argument"),

+ CASE_EXPRESSION_SHOULD_BE_INT_STRING(ErrorSeverity.ERROR,

+ "Case expression should be compiler-time constant of type 'int' or 'String', '%s' found"),

+ CASE_EXPRESSIONS_SHOULD_BE_SAME_TYPE(ErrorSeverity.ERROR,

+ "All case expressions should be compiler-time constants of the same type - 'int' or 'String'. '%s' expected but '%s' found"),

EXTRA_ARGUMENT("extra argument"),

FIELD_HAS_NO_GETTER("Field '%s' has no getter"),

FIELD_HAS_NO_SETTER("Field '%s' has no setter"),