Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Issue 10540022: mac: Plumbing for the emoji font. (Closed)

Created:
8 years, 6 months ago by Nico
Modified:
8 years, 2 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, bashi
Visibility:
Public.

Description

mac: Plumbing for the emoji font. Since emoji is disabled in webkit for chromium, this has no observable effect yet. BUG=62435 TEST=none TBR=tony Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=160338

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : cargo cult more #

Patch Set 4 : cargo cult more #

Patch Set 5 : tweakrebase #

Patch Set 6 : . #

Patch Set 7 : comments falken #

Total comments: 2

Patch Set 8 : whoops #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -0 lines) Patch
M chrome/app/resources/locale_settings_cros.grd View 1 2 3 4 1 chunk +5 lines, -0 lines 1 comment Download
M chrome/app/resources/locale_settings_linux.grd View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_mac.grd View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/app/resources/locale_settings_win.grd View 1 2 3 4 1 chunk +5 lines, -0 lines 1 comment Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper.cc View 1 2 3 4 5 6 3 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/prefs/prefs_tab_helper_browsertest.cc View 1 2 3 4 5 6 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/common/pref_names.h View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
M webkit/glue/webpreferences.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webpreferences.cc View 1 2 3 4 5 3 chunks +14 lines, -0 lines 1 comment Download

Messages

Total messages: 11 (0 generated)
Nico
Hi Tony, I admit I don't fully comprehend what I'm doing here. I just looked ...
8 years, 2 months ago (2012-10-05 04:09:46 UTC) #1
Nico
If you like what you're seeing then a) let me compliment you on your excellent ...
8 years, 2 months ago (2012-10-05 04:36:42 UTC) #2
falken
lgtm https://chromiumcodereview.appspot.com/10540022/diff/21001/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm File chrome/browser/ui/cocoa/web_intent_sheet_controller.mm (right): https://chromiumcodereview.appspot.com/10540022/diff/21001/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm#newcode1110 chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:1110: if (model_) {// && model_->IsWaitingForSuggestions()) { I think ...
8 years, 2 months ago (2012-10-05 05:40:47 UTC) #3
Nico
https://chromiumcodereview.appspot.com/10540022/diff/21001/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm File chrome/browser/ui/cocoa/web_intent_sheet_controller.mm (right): https://chromiumcodereview.appspot.com/10540022/diff/21001/chrome/browser/ui/cocoa/web_intent_sheet_controller.mm#newcode1110 chrome/browser/ui/cocoa/web_intent_sheet_controller.mm:1110: if (model_) {// && model_->IsWaitingForSuggestions()) { On 2012/10/05 05:40:47, ...
8 years, 2 months ago (2012-10-05 05:41:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10540022/17002
8 years, 2 months ago (2012-10-05 05:45:33 UTC) #5
commit-bot: I haz the power
Presubmit check for 10540022-17002 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 2 months ago (2012-10-05 05:45:38 UTC) #6
Nico
tony, since falken reviewed this and the changes in webkit are fairly mechanic, I'm tbr'ing ...
8 years, 2 months ago (2012-10-05 05:46:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/10540022/17002
8 years, 2 months ago (2012-10-05 05:47:04 UTC) #8
commit-bot: I haz the power
Change committed as 160338
8 years, 2 months ago (2012-10-05 08:56:05 UTC) #9
jungshik at Google
I realized that this has been checked in, but CrOS and Windows font pref. entries ...
8 years, 2 months ago (2012-10-05 17:25:41 UTC) #10
tony
8 years, 2 months ago (2012-10-05 17:35:22 UTC) #11
https://chromiumcodereview.appspot.com/10540022/diff/17002/webkit/glue/webpre...
File webkit/glue/webpreferences.cc (right):

https://chromiumcodereview.appspot.com/10540022/diff/17002/webkit/glue/webpre...
webkit/glue/webpreferences.cc:138: ASCIIToUTF16("Times New Roman");
Do we ever end up using the default value?  Do we really need the #ifs?

Powered by Google App Engine
This is Rietveld 408576698