Issue 10539114: Revert 141693 - Add relaunch prompt to linux help page.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10539114: Revert 141693 - Add relaunch prompt to linux help page. (Closed)

Created:
8 years, 6 months ago by sail

Modified:
8 years, 6 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 141693 - Add relaunch prompt to linux help page. This doesn't allow you to check for updates or show progress, it just notifies you if a new version is ready. As such, I didn't see a reason to limit it to Google Chrome builds. This also fixes a bug where a 'disabled' state permanently hides the status text. BUG=117403 TEST=manual with --check-for-update-interval=1 and manually editing the version Review URL: https://chromiumcodereview.appspot.com/10541013 TBR=estade@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141711

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -89 lines)			Patch
M	chrome/browser/resources/help/help.html	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/resources/help/help.js	View	1 chunk	+8 lines, -7 lines	0 comments	Download
MM	chrome/browser/ui/webui/help/help_browsertest.js	View	1 chunk	+0 lines, -21 lines	0 comments	Download
D	chrome/browser/ui/webui/help/version_updater_basic.h	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	chrome/browser/ui/webui/help/version_updater_basic.cc	View	1 chunk	+0 lines, -25 lines	0 comments	Download
A +	chrome/browser/ui/webui/help/version_updater_unimplemented.h	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	chrome/browser/ui/webui/help/version_updater_unimplemented.cc	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	3 chunks	+6 lines, -6 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages