Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 10541013: Add relaunch prompt to linux help page. (Closed)

Created:
8 years, 6 months ago by Evan Stade
Modified:
8 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, arv (Not doing code reviews)
Visibility:
Public.

Description

Add relaunch prompt to linux help page. This doesn't allow you to check for updates or show progress, it just notifies you if a new version is ready. As such, I didn't see a reason to limit it to Google Chrome builds. This also fixes a bug where a 'disabled' state permanently hides the status text. BUG=117403 TEST=manual with --check-for-update-interval=1 and manually editing the version Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141693

Patch Set 1 #

Patch Set 2 : add test #

Patch Set 3 : conditionalize test #

Patch Set 4 : actually add new files #

Patch Set 5 : fix mac chromium #

Patch Set 6 : fix win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -56 lines) Patch
M chrome/browser/resources/help/help.html View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/help/help.js View 1 2 3 4 5 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/help/help_browsertest.js View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/help/version_updater_basic.h View 1 2 3 1 chunk +30 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/help/version_updater_basic.cc View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
D chrome/browser/ui/webui/help/version_updater_unimplemented.h View 1 chunk +0 lines, -31 lines 0 comments Download
D chrome/browser/ui/webui/help/version_updater_unimplemented.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Evan Stade
8 years, 6 months ago (2012-06-05 20:27:53 UTC) #1
Dan Beam
where's the test[s]? :D
8 years, 6 months ago (2012-06-05 20:58:36 UTC) #2
Evan Stade
added a test.
8 years, 6 months ago (2012-06-05 21:30:54 UTC) #3
Dan Beam
awesome, thanks! the bots will decide your fate now! lgtm
8 years, 6 months ago (2012-06-05 21:51:23 UTC) #4
Evan Stade
may want to re-review the files that were added
8 years, 6 months ago (2012-06-08 02:18:21 UTC) #5
Dan Beam
slgtm
8 years, 6 months ago (2012-06-09 00:42:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10541013/6004
8 years, 6 months ago (2012-06-12 02:32:42 UTC) #7
commit-bot: I haz the power
Try job failure for 10541013-6004 (retry) (retry) on win_rel for step "browser_tests". It's a second ...
8 years, 6 months ago (2012-06-12 05:56:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10541013/1009
8 years, 6 months ago (2012-06-12 17:13:39 UTC) #9
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 18:44:51 UTC) #10
Change committed as 141693

Powered by Google App Engine
This is Rietveld 408576698