Issue 10539109: Do not convert a Dart closure parameter to a JS closure if the parameter was not provided.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10539109: Do not convert a Dart closure parameter to a JS closure if the parameter was not provided. (Closed)

Created:
8 years, 6 months ago by ngeoffray

Modified:
8 years, 6 months ago

Reviewers:
sra1, kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Do not convert a Dart closure parameter to a JS closure if the parameter was not provided. Committed: https://code.google.com/p/dart/source/detail?r=8552

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -3 lines)			Patch
	M	frog/tests/frog_native/native_wrapping_function2_frog_test.dart	View		2 chunks	+6 lines, -0 lines	0 comments	Download
	M	lib/compiler/implementation/native_emitter.dart	View		2 chunks	+7 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

kasperl

8 years, 6 months ago (2012-06-12 15:01:40 UTC) #2

LGTM. The code in the native emitter is a bit hairy, but this looks like a good
fix for a real problem.