Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: frog/tests/frog_native/native_wrapping_function2_frog_test.dart

Issue 10539109: Do not convert a Dart closure parameter to a JS closure if the parameter was not provided. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/compiler/implementation/native_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/tests/frog_native/native_wrapping_function2_frog_test.dart
===================================================================
--- frog/tests/frog_native/native_wrapping_function2_frog_test.dart (revision 8546)
+++ frog/tests/frog_native/native_wrapping_function2_frog_test.dart (working copy)
@@ -10,6 +10,8 @@
foo0(Callback0 closure) native "return closure();";
foo1(Callback1 closure, arg1) native "return closure(arg1);";
foo2(Callback2 closure, arg1, arg2) native "return closure(arg1, arg2);";
+ foo3([Callback0 closure]) native
+ "return closure == (void 0) ? 42 : closure();";
}
makeA() native;
@@ -26,9 +28,13 @@
Expect.equals(42, a.foo0(() => 42));
Expect.equals(43, a.foo1((arg1) => arg1, 43));
Expect.equals(44, a.foo2((arg1, arg2) => arg1 + arg2, 21, 23));
+ Expect.equals(42, a.foo3());
+ Expect.equals(43, a.foo3(() => 43));
A aa = a;
Expect.equals(42, aa.foo0(() => 42));
Expect.equals(43, aa.foo1((arg1) => arg1, 43));
Expect.equals(44, aa.foo2((arg1, arg2) => arg1 + arg2, 21, 23));
+ Expect.equals(42, aa.foo3());
+ Expect.equals(43, aa.foo3(() => 43));
}
« no previous file with comments | « no previous file | lib/compiler/implementation/native_emitter.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698