lib/compiler/implementation/ssa/codegen.dart - Issue 10539042: Recognize nested logical operations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/ssa/codegen.dart

Issue 10539042: Recognize nested logical operations. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/compiler/implementation/ssa/codegen.dart

===================================================================

--- lib/compiler/implementation/ssa/codegen.dart (revision 8378)

+++ lib/compiler/implementation/ssa/codegen.dart (working copy)

@@ -1724,7 +1724,7 @@

}

visitPhi(HPhi node) {

- HBasicBlock ifBlock = node.block.predecessors[0].predecessors[0];

+ HBasicBlock ifBlock = node.block.dominator;

// This method is only called for phis that are generated at use

floitsch 2012/06/07 09:23:24 Move the comment before the first line of the func

ngeoffray 2012/06/07 10:05:48 Done.

// site. A phi can be generated at use site only if it is the

// result of a logical operation.

« no previous file with comments | « no previous file | lib/compiler/implementation/ssa/codegen_helpers.dart » ('j') | no next file with comments »