Recognize nested logical operations.

lib/compiler/implementation/ssa/codegen.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class SsaCodeGeneratorTask extends CompilerTask {
   final JavaScriptBackend backend;
   SsaCodeGeneratorTask(JavaScriptBackend backend)
       : this.backend = backend,
         super(backend.compiler);
   String get name() => 'SSA code generator';
@@ skipping 1706 matching lines @@
       endExpression(JSPrecedence.PREFIX_PRECEDENCE);
     }
   }
 
   visitParameterValue(HParameterValue node) {
     assert(isGenerateAtUseSite(node));
     buffer.add(variableNames.getName(node));
   }
 
   visitPhi(HPhi node) {
-    HBasicBlock ifBlock = node.block.predecessors[0].predecessors[0];
+    HBasicBlock ifBlock = node.block.dominator;
     // This method is only called for phis that are generated at use

[floitsch, 2012/06/07 09:23:24]

Move the comment before the first line of the function.

[ngeoffray, 2012/06/07 10:05:48]

Done.

     // site. A phi can be generated at use site only if it is the
     // result of a logical operation.
     assert(logicalOperations.contains(ifBlock.last));
     HInstruction input = ifBlock.last.inputs[0];
     if (input.isConstantFalse()) {
       use(node.inputs[1], expectedPrecedence);
     } else if (input.isConstantTrue()) {
       use(node.inputs[0], expectedPrecedence);
     } else {
       String operation = node.inputs[1].isConstantFalse() ? '&&' : '||';
@@ skipping 934 matching lines @@
       startBailoutSwitch();
     }
   }
 
   void endLabeledBlock(HLabeledBlockInformation labeledBlockInfo) {
     if (labeledBlockInfo.body.start.hasGuards()) {
       endBailoutSwitch();
     }
   }
 }