Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 10539041: It broke win aura bot (Closed)

Created:
8 years, 6 months ago by loislo
Modified:
8 years, 6 months ago
Reviewers:
varunjain
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, jochen+watch-content_chromium.org, ben+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

It broke win aura bot [ RUN ] WindowTest.TransferCaptureTouchEvents .\window_unittest.cc(700): error: Value of: d1.gesture_event_count() Actual: 2 Expected: 1 .\window_unittest.cc(710): error: Value of: d2.gesture_event_count() Actual: 2 Expected: 1 [ FAILED ] WindowTest.TransferCaptureTouchEvents (0 ms) Revert 140967 - Fix TAP_DOWN gesture event: 1. GESTURE_TAP_DOWN should be sent only on the first TOUCH_PRESSED. 2. New gesture GESTURE_BEGIN shuold be sent on all TOUCH_PRESSED. 3. Rename GESTURE_TAP_UP to GESTURE_END. BUG=131007 TEST=manual Review URL: https://chromiumcodereview.appspot.com/10533029 TBR=varunjain@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140972

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -123 lines) Patch
M ash/wm/system_gesture_event_filter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/renderer_host/web_input_event_aurax11.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 39 chunks +7 lines, -67 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 5 chunks +10 lines, -13 lines 0 comments Download
M ui/aura/window_unittest.cc View 3 chunks +3 lines, -6 lines 0 comments Download
M ui/base/events.h View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/base/gestures/gesture_sequence.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/base/gestures/gesture_sequence.cc View 4 chunks +4 lines, -18 lines 0 comments Download
M ui/views/view_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 1 chunk +3 lines, -5 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
loislo
8 years, 6 months ago (2012-06-07 06:33:02 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698