Minor style cleanup in metrics_reporting_scheduler.*

Minor style cleanup in metrics_reporting_scheduler.*

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141543

[jar (doing other things), 2012-06-08 00:20:02]

https://chromiumcodereview.appspot.com/10539039/diff/2001/chrome/browser/metr...
File chrome/browser/metrics/metrics_reporting_scheduler.cc (left):

https://chromiumcodereview.appspot.com/10539039/diff/2001/chrome/browser/metr...
chrome/browser/metrics/metrics_reporting_scheduler.cc:14: static const int
kInitialUploadIntervalSeconds = 60;
I'm surprised you pulled the static qualifier. Won't that cause the vars to have
extern linkage (i.e., be visible at the linker level)?

Usually, we either use an anonymous namespace, or static, to preclude that.

[Ilya Sherman, 2012-06-08 00:52:14]

https://chromiumcodereview.appspot.com/10539039/diff/2001/chrome/browser/metr...
File chrome/browser/metrics/metrics_reporting_scheduler.cc (left):

https://chromiumcodereview.appspot.com/10539039/diff/2001/chrome/browser/metr...
chrome/browser/metrics/metrics_reporting_scheduler.cc:14: static const int
kInitialUploadIntervalSeconds = 60;
On 2012/06/08 00:20:02, jar wrote:
> I'm surprised you pulled the static qualifier. Won't that cause the vars to
have
> extern linkage (i.e., be visible at the linker level)?
> 
> Usually, we either use an anonymous namespace, or static, to preclude that.

Numeric constants don't seem to require either, but I've gone ahead and wrapped
these in an anonymous namespace to be extra sure.  (I know, I could probably
just leave the "static"... but that doesn't match the style I've seen in other
files, and so I find it surprising when reading through the code.)

[jar (doing other things), 2012-06-11 18:54:28]

lgtm

https://chromiumcodereview.appspot.com/10539039/diff/2001/chrome/browser/metr...
File chrome/browser/metrics/metrics_reporting_scheduler.cc (left):

https://chromiumcodereview.appspot.com/10539039/diff/2001/chrome/browser/metr...
chrome/browser/metrics/metrics_reporting_scheduler.cc:14: static const int
kInitialUploadIntervalSeconds = 60;
If I had my druthers.... I'd suggest that Chromium use the static qualifier, as
it makes it easier to grep the code etc. ...but no one asked me ;-).

The only restriction is that static doesn't work for classes <sigh>, so for them
you need the anonymous namespace.

On 2012/06/08 00:52:14, Ilya Sherman wrote:
> On 2012/06/08 00:20:02, jar wrote:
> > I'm surprised you pulled the static qualifier. Won't that cause the vars to
> have
> > extern linkage (i.e., be visible at the linker level)?
> > 
> > Usually, we either use an anonymous namespace, or static, to preclude that.
> 
> Numeric constants don't seem to require either, but I've gone ahead and
wrapped
> these in an anonymous namespace to be extra sure.  (I know, I could probably
> just leave the "static"... but that doesn't match the style I've seen in other
> files, and so I find it surprising when reading through the code.)

[commit-bot: I haz the power, 2012-06-11 21:59:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/isherman@chromium.org/10539039/5001

[commit-bot: I haz the power, 2012-06-11 22:53:22]

Change committed as 141543