| Index: chrome/browser/metrics/metrics_reporting_scheduler.cc
|
| diff --git a/chrome/browser/metrics/metrics_reporting_scheduler.cc b/chrome/browser/metrics/metrics_reporting_scheduler.cc
|
| index 67caa73bf2bcddc472647c65e98fdd7e816c5f0e..e4f0461f9492f4087155dff3dfa8bb2b2e4da15e 100644
|
| --- a/chrome/browser/metrics/metrics_reporting_scheduler.cc
|
| +++ b/chrome/browser/metrics/metrics_reporting_scheduler.cc
|
| @@ -7,28 +7,30 @@
|
| #include "base/compiler_specific.h"
|
| #include "chrome/browser/metrics/metrics_service.h"
|
|
|
| -using base::Time;
|
| using base::TimeDelta;
|
|
|
| +namespace {
|
| +
|
| // The delay, in seconds, after startup before sending the first log message.
|
| -static const int kInitialUploadIntervalSeconds = 60;
|
| +const int kInitialUploadIntervalSeconds = 60;
|
|
|
| // The delay, in seconds, between uploading when there are queued logs from
|
| // previous sessions to send.
|
| -static const int kUnsentLogsIntervalSeconds = 15;
|
| +const int kUnsentLogsIntervalSeconds = 15;
|
|
|
| // Standard interval between log uploads, in seconds.
|
| -static const int kStandardUploadIntervalSeconds = 30 * 60; // Thirty minutes.
|
| +const int kStandardUploadIntervalSeconds = 30 * 60; // Thirty minutes.
|
|
|
| // When uploading metrics to the server fails, we progressively wait longer and
|
| // longer before sending the next log. This backoff process helps reduce load
|
| // on a server that is having issues.
|
| // The following is the multiplier we use to expand that inter-log duration.
|
| -static const double kBackoffMultiplier = 1.1;
|
| +const double kBackoffMultiplier = 1.1;
|
|
|
| // The maximum backoff multiplier.
|
| -static const int kMaxBackoffMultiplier = 10;
|
| +const int kMaxBackoffMultiplier = 10;
|
|
|
| +} // anonymous namespace
|
|
|
| MetricsReportingScheduler::MetricsReportingScheduler(
|
| const base::Closure& upload_callback)
|
| @@ -42,7 +44,7 @@ MetricsReportingScheduler::~MetricsReportingScheduler() {}
|
|
|
| void MetricsReportingScheduler::Start() {
|
| running_ = true;
|
| - ScheduleNextCallback();
|
| + ScheduleNextUpload();
|
| }
|
|
|
| void MetricsReportingScheduler::Stop() {
|
| @@ -67,14 +69,14 @@ void MetricsReportingScheduler::UploadFinished(bool server_is_healthy,
|
| }
|
|
|
| if (running_)
|
| - ScheduleNextCallback();
|
| + ScheduleNextUpload();
|
| }
|
|
|
| void MetricsReportingScheduler::UploadCancelled() {
|
| DCHECK(callback_pending_);
|
| callback_pending_ = false;
|
| if (running_)
|
| - ScheduleNextCallback();
|
| + ScheduleNextUpload();
|
| }
|
|
|
| void MetricsReportingScheduler::TriggerUpload() {
|
| @@ -82,7 +84,7 @@ void MetricsReportingScheduler::TriggerUpload() {
|
| upload_callback_.Run();
|
| }
|
|
|
| -void MetricsReportingScheduler::ScheduleNextCallback() {
|
| +void MetricsReportingScheduler::ScheduleNextUpload() {
|
| DCHECK(running_);
|
| if (upload_timer_.IsRunning() || callback_pending_)
|
| return;
|
| @@ -92,7 +94,7 @@ void MetricsReportingScheduler::ScheduleNextCallback() {
|
| }
|
|
|
| void MetricsReportingScheduler::BackOffUploadInterval() {
|
| - DCHECK(kBackoffMultiplier > 1.0);
|
| + DCHECK_GT(kBackoffMultiplier, 1.0);
|
| upload_interval_ = TimeDelta::FromMicroseconds(
|
| static_cast<int64>(kBackoffMultiplier *
|
| upload_interval_.InMicroseconds()));
|
|
|