|
|
Reland 140878 - cleanup: Remove applist v1 code.
- Remove obsolete v1 code and test;
- Grid rid of selected_ in AppListItemModel and solely use selected_item_index_
in AppsGridView;
- Fix a bug that highlighted item might not be visible and add test to cover it;
- Update DEPS;
- Fix broken ExtensionInstallUIBrowserTest.AppInstallConfirmation casued by
wrong destruction order introduced by r140878 moving app list container on top
of launcher container. Fix is to explicitly release app list contoller before
launcher container.
BUG= 125964
TEST=Verify app list always show up as bubble and app_list_unittests should pass.
Review URL: https://chromiumcodereview.appspot.com/10533032
TBR=sky@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140959
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+287 lines, -645 lines) |
Patch |
 |
M |
ash/ash_switches.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
|
M |
ash/ash_switches.cc
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
|
M |
ash/shell.cc
|
View
|
1
|
3 chunks |
+9 lines, -15 lines |
0 comments
|
Download
|
|
M |
ash/wm/app_list_controller.h
|
View
|
|
2 chunks |
+1 line, -17 lines |
0 comments
|
Download
|
|
M |
ash/wm/app_list_controller.cc
|
View
|
|
8 chunks |
+10 lines, -120 lines |
0 comments
|
Download
|
|
M |
chrome/app/generated_resources.grd
|
View
|
|
1 chunk |
+0 lines, -6 lines |
0 comments
|
Download
|
|
M |
chrome/browser/about_flags.cc
|
View
|
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
|
M |
ui/app_list/DEPS
|
View
|
|
1 chunk |
+2 lines, -2 lines |
0 comments
|
Download
|
|
M |
ui/app_list/app_list.gyp
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
|
M |
ui/app_list/app_list_item_view.h
|
View
|
|
3 chunks |
+4 lines, -22 lines |
0 comments
|
Download
|
|
M |
ui/app_list/app_list_item_view.cc
|
View
|
|
10 chunks |
+31 lines, -152 lines |
0 comments
|
Download
|
|
M |
ui/app_list/app_list_view.h
|
View
|
|
4 chunks |
+2 lines, -18 lines |
0 comments
|
Download
|
|
M |
ui/app_list/app_list_view.cc
|
View
|
|
13 chunks |
+41 lines, -137 lines |
0 comments
|
Download
|
|
M |
ui/app_list/apps_grid_view.h
|
View
|
|
3 chunks |
+3 lines, -15 lines |
0 comments
|
Download
|
|
M |
ui/app_list/apps_grid_view.cc
|
View
|
|
5 chunks |
+15 lines, -79 lines |
0 comments
|
Download
|
|
M |
ui/app_list/apps_grid_view_unittest.cc
|
View
|
|
1 chunk |
+92 lines, -50 lines |
0 comments
|
Download
|
|
A |
ui/app_list/test/app_list_test_suite.h
|
View
|
|
1 chunk |
+31 lines, -0 lines |
0 comments
|
Download
|
|
A |
ui/app_list/test/app_list_test_suite.cc
|
View
|
|
1 chunk |
+34 lines, -0 lines |
0 comments
|
Download
|
|
A |
ui/app_list/test/run_all_unittests.cc
|
View
|
|
1 chunk |
+9 lines, -0 lines |
0 comments
|
Download
|
Total messages: 2 (0 generated)
|
Chromium Code Reviews
Issue
10539038:
Reland 140878 - cleanup: Remove applist v1 code. (Closed)
