Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 10533032: cleanup: Remove applist v1 code. (Closed)

Created:
8 years, 6 months ago by xiyuan
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

cleanup: Remove applist v1 code. - Remove obsolete v1 code and test; - Grid rid of selected_ in AppListItemModel and solely use selected_item_index_ in AppsGridView; - Fix a bug that highlighted item might not be visible and add test to cover it; - Update DEPS; BUG=125964 TEST=Verify app list always show up as bubble and app_list_unittests should pass. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=140878

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -676 lines) Patch
M ash/ash_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M ash/ash_switches.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M ash/shell.cc View 1 chunk +3 lines, -14 lines 0 comments Download
M ash/wm/app_list_controller.h View 2 chunks +1 line, -17 lines 0 comments Download
M ash/wm/app_list_controller.cc View 8 chunks +10 lines, -120 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M ui/app_list/DEPS View 1 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 chunk +3 lines, -1 line 0 comments Download
M ui/app_list/app_list_item_view.h View 3 chunks +4 lines, -22 lines 0 comments Download
M ui/app_list/app_list_item_view.cc View 1 10 chunks +31 lines, -152 lines 0 comments Download
M ui/app_list/app_list_view.h View 4 chunks +2 lines, -18 lines 0 comments Download
M ui/app_list/app_list_view.cc View 13 chunks +41 lines, -137 lines 0 comments Download
M ui/app_list/apps_grid_view.h View 3 chunks +3 lines, -15 lines 0 comments Download
M ui/app_list/apps_grid_view.cc View 5 chunks +15 lines, -79 lines 0 comments Download
M ui/app_list/apps_grid_view_unittest.cc View 1 chunk +92 lines, -50 lines 0 comments Download
A + ui/app_list/test/app_list_test_suite.h View 1 1 chunk +9 lines, -10 lines 0 comments Download
A + ui/app_list/test/app_list_test_suite.cc View 1 chunk +9 lines, -20 lines 0 comments Download
A + ui/app_list/test/run_all_unittests.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
We will only have v2 for M21. So clean it up.
8 years, 6 months ago (2012-06-06 20:30:27 UTC) #1
sky
LGTM
8 years, 6 months ago (2012-06-06 20:53:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10533032/11001
8 years, 6 months ago (2012-06-06 22:00:54 UTC) #3
commit-bot: I haz the power
8 years, 6 months ago (2012-06-06 23:17:46 UTC) #4
Change committed as 140878

Powered by Google App Engine
This is Rietveld 408576698