Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 10538093: [Mac] Log OnChannelError() bt for CHECK in bug 97285. (Closed)

Created:
8 years, 6 months ago by Scott Hess - ex-Googler
Modified:
8 years, 6 months ago
Reviewers:
brettw, piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Mac] Log OnChannelError() bt for CHECK in bug 97285. http://crrev.com/137896 added code to capture RemoveRoute() called during setup of the channel, for instance if a nested call happened during a sync call. This adds the same check for OnChannelError(). BUG=97285 TEST=crash server. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141615

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M content/renderer/plugin_channel_host.cc View 2 chunks +13 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Scott Hess - ex-Googler
kbr's comments let me (apparently) repro the crash last week, but this week, nada. So ...
8 years, 6 months ago (2012-06-11 22:22:21 UTC) #1
brettw
lgtm
8 years, 6 months ago (2012-06-11 22:24:50 UTC) #2
piman
lgtm
8 years, 6 months ago (2012-06-11 22:53:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10538093/1
8 years, 6 months ago (2012-06-12 00:48:45 UTC) #4
commit-bot: I haz the power
Try job failure for 10538093-1 (retry) on mac_rel for step "runhooks". It's a second try, ...
8 years, 6 months ago (2012-06-12 00:55:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shess@chromium.org/10538093/1
8 years, 6 months ago (2012-06-12 03:21:56 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 04:57:38 UTC) #7
Change committed as 141615

Powered by Google App Engine
This is Rietveld 408576698