Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1901)

Unified Diff: content/renderer/plugin_channel_host.cc

Issue 10538093: [Mac] Log OnChannelError() bt for CHECK in bug 97285. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/plugin_channel_host.cc
diff --git a/content/renderer/plugin_channel_host.cc b/content/renderer/plugin_channel_host.cc
index 52c9632856da4c7ffd5ac9cc7a9dd53617a44d99..009c651133d72a5de9fe791ecf55bbf9e415f0c2 100644
--- a/content/renderer/plugin_channel_host.cc
+++ b/content/renderer/plugin_channel_host.cc
@@ -36,6 +36,9 @@ namespace {
// Breakpad key for the RemoveRoute() backtrace.
const char* kRemoveRouteTraceKey = "remove_route_bt";
+// Breakpad key for the OnChannelError() backtrace.
+const char* kChannelErrorTraceKey = "channel_error_bt";
+
// GetRemoveTrackingFlag() exposes this so that
// WebPluginDelegateProxy::Initialize() can do scoped set/reset. When
// true, RemoveRoute() knows WBDP::Initialize() is on the stack, and
@@ -202,6 +205,16 @@ bool PluginChannelHost::Send(IPC::Message* msg) {
}
void PluginChannelHost::OnChannelError() {
+#if defined(OS_MACOSX)
+ if (remove_tracking) {
+ base::debug::StackTrace trace;
+ size_t count = 0;
+ const void* const* addresses = trace.Addresses(&count);
+ base::mac::SetCrashKeyFromAddresses(
+ base::SysUTF8ToNSString(kChannelErrorTraceKey), addresses, count);
+ }
+#endif
+
NPChannelBase::OnChannelError();
for (ProxyMap::iterator iter = proxies_.begin();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698