Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: remoting/webapp/main.html

Issue 10537182: The user's consent to crash dumps reporting can now be set via the UI (Windows only). The checkbox … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« remoting/webapp/main.css ('K') | « remoting/webapp/main.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/main.html
diff --git a/remoting/webapp/main.html b/remoting/webapp/main.html
index 1c1d8223c5e2fb83561a99b36321b4b09d68951b..22965592f236bbe73088cee0c10c5d08286352fe 100644
--- a/remoting/webapp/main.html
+++ b/remoting/webapp/main.html
@@ -221,6 +221,18 @@ found in the LICENSE file.
</td>
<tr>
</table>
+ <table>
Jamie 2012/06/14 23:43:56 Is a second table needed for the check-box? We sho
alexeypa (please no reviews) 2012/06/19 23:27:29 I couldn't make it work without the table. I tries
Jamie 2012/06/21 18:47:52 I think for this CL we can just take any approach
alexeypa (please no reviews) 2012/06/21 23:30:25 I actually was able to got rid of table, just forg
+ <tr>
+ <td>
+ <input id="usagestats-consent" type="checkbox">
+ </td>
+ <td>
+ <label id="usagestats-consent-label" for="usagestats-consent">
+ <span i18n-content="HOST_SETUP_CRASH_REPORTING_MESSAGE"></span>
Jamie 2012/06/14 23:43:56 Nit: Split at the close of the <span> tag to keep
alexeypa (please no reviews) 2012/06/19 23:27:29 Done.
+ </label>
+ </td>
+ </tr>
+ </table>
<div id="daemon-pin-error-div" class="message centered" hidden>
<span id="daemon-pin-error-message" class="error-state">
</span>
« remoting/webapp/main.css ('K') | « remoting/webapp/main.css ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698