remoting/webapp/main.html - Issue 10537182: The user's consent to crash dumps reporting can now be set via the UI (Windows only). The checkbox …

Side by Side Diff: remoting/webapp/main.html

Issue 10537182: The user's consent to crash dumps reporting can now be set via the UI (Windows only). The checkbox … (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 <!doctype html>	1 <!doctype html>

2 <!--	2 <!--

3 Copyright (c) 2012 The Chromium Authors. All rights reserved.	3 Copyright (c) 2012 The Chromium Authors. All rights reserved.

4 Use of this source code is governed by a BSD-style license that can be	4 Use of this source code is governed by a BSD-style license that can be

5 found in the LICENSE file.	5 found in the LICENSE file.

6 -->	6 -->

7	7

8 <html>	8 <html>

9 <head>	9 <head>

10 <meta charset="utf-8">	10 <meta charset="utf-8">

(...skipping 203 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
214 <tr>	214 <tr>

215 <td class="table-label">	215 <td class="table-label">

216 <label for="daemon-pin-confirm"	216 <label for="daemon-pin-confirm"

217 i18n-content="ASK_PIN_DIALOG_CONFIRM_LABEL"></label>	217 i18n-content="ASK_PIN_DIALOG_CONFIRM_LABEL"></label>

218 </td>	218 </td>

219 <td>	219 <td>

220 <input id="daemon-pin-confirm" type="password">	220 <input id="daemon-pin-confirm" type="password">

221 </td>	221 </td>

222 <tr>	222 <tr>

223 </table>	223 </table>

	224 <table>
	Jamie 2012/06/14 23:43:56 Is a second table needed for the check-box? We sho Is a second table needed for the check-box? We shouldn't use tables for non-tabular data (I wasn't happy about using one to lay out the PIN entry and confirmation, but couldn't see any alternative). alexeypa (please no reviews) 2012/06/19 23:27:29 I couldn't make it work without the table. I tries Show quoted text On 2012/06/14 23:43:56, Jamie wrote: > Is a second table needed for the check-box? We shouldn't use tables for > non-tabular data (I wasn't happy about using one to lay out the PIN entry and > confirmation, but couldn't see any alternative). I couldn't make it work without the table. I tries playing with float but it didn't work out. I'm open to suggestions. Jamie 2012/06/21 18:47:52 I think for this CL we can just take any approach Show quoted text On 2012/06/19 23:27:29, alexeypa wrote: > On 2012/06/14 23:43:56, Jamie wrote: > > Is a second table needed for the check-box? We shouldn't use tables for > > non-tabular data (I wasn't happy about using one to lay out the PIN entry and > > confirmation, but couldn't see any alternative). > > I couldn't make it work without the table. I tries playing with float but it > didn't work out. I'm open to suggestions. I think for this CL we can just take any approach that works. I'll take a look at cleaning it up as a more focused effort (or you can do it yourself if you want to brush up on HTML/CSS). Can you raise an M22 bug, assign it to one of us and add a TODO here and/or to the CSS? alexeypa (please no reviews) 2012/06/21 23:30:25 I actually was able to got rid of table, just forg Show quoted text On 2012/06/21 18:47:52, Jamie wrote: > > I couldn't make it work without the table. I tries playing with float but it > > didn't work out. I'm open to suggestions. > I think for this CL we can just take any approach that works. I'll take a look > at cleaning it up as a more focused effort (or you can do it yourself if you > want to brush up on HTML/CSS). Can you raise an M22 bug, assign it to one of us > and add a TODO here and/or to the CSS? I actually was able to got rid of table, just forgot to update this comment. It should've been "Done".
	225 <tr>

	226 <td>

	227 <input id="usagestats-consent" type="checkbox">

	228 </td>

	229 <td>

	230 <label id="usagestats-consent-label" for="usagestats-consent">

	231 <span i18n-content="HOST_SETUP_CRASH_REPORTING_MESSAGE"></span >
	Jamie 2012/06/14 23:43:56 Nit: Split at the close of the <span> tag to keep Nit: Split at the close of the <span> tag to keep below 80-characters. alexeypa (please no reviews) 2012/06/19 23:27:29 Done. Show quoted text On 2012/06/14 23:43:56, Jamie wrote: > Nit: Split at the close of the <span> tag to keep below 80-characters. Done.
	232 </label>

	233 </td>

	234 </tr>

	235 </table>

224 <div id="daemon-pin-error-div" class="message centered" hidden>	236 <div id="daemon-pin-error-div" class="message centered" hidden>

225 <span id="daemon-pin-error-message" class="error-state">	237 <span id="daemon-pin-error-message" class="error-state">

226 </span>	238 </span>

227 </div>	239 </div>

228 <div class="box">	240 <div class="box">

229 <a href="https://support.google.com/chrome/?p=ui_pin_safety"	241 <a href="https://support.google.com/chrome/?p=ui_pin_safety"

230 target="_blank"	242 target="_blank"

231 id="why-is-this-safe"	243 id="why-is-this-safe"

232 i18n-content="WHY_IS_THIS_SAFE"></a>	244 i18n-content="WHY_IS_THIS_SAFE"></a>

233 <div class="box-spacer"></div>	245 <div class="box-spacer"></div>

(...skipping 337 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
571 <div class="arrow-down"></div>	583 <div class="arrow-down"></div>

572 </div>	584 </div>

573 </div> <!-- session-toolbar -->	585 </div> <!-- session-toolbar -->

574 </div> <!-- session-mode -->	586 </div> <!-- session-mode -->

575	587

576 <div id="statistics" dir="ltr" class="selectable" hidden>	588 <div id="statistics" dir="ltr" class="selectable" hidden>

577 </div> <!-- statistics -->	589 </div> <!-- statistics -->

578	590

579 </body>	591 </body>

580 </html>	592 </html>

OLD	NEW

« remoting/webapp/main.css ('K') | « remoting/webapp/main.css ('k') | no next file » | no next file with comments »