Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 10537128: Allow non integer device scale factors in render widget (Closed)

Created:
8 years, 6 months ago by Ian Vollick
Modified:
8 years, 6 months ago
Reviewers:
Avi (use Gerrit), piman
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch-content_chromium.org, rjkroege, Rick Byers
Visibility:
Public.

Description

Allow non integer device scale factors in render widget Currently we force device scale factors to integers in render widget preventing us from experimenting with non integer default device scale factors. This patch fixes that. BUG=None TEST=Use a default device scale factor of 1.5 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142951

Patch Set 1 #

Patch Set 2 : . #

Total comments: 1

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_widget.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 chunks +9 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
Ian Vollick
8 years, 6 months ago (2012-06-12 17:51:51 UTC) #1
piman
I think it's ok to experiment, but are we guaranteed that it still has an ...
8 years, 6 months ago (2012-06-12 19:21:06 UTC) #2
Ian Vollick
On 2012/06/12 19:21:06, piman wrote: > I think it's ok to experiment, but are we ...
8 years, 6 months ago (2012-06-19 02:48:44 UTC) #3
Ian Vollick
+rbyers (Sorry for the spam). On 2012/06/19 02:48:44, vollick wrote: > On 2012/06/12 19:21:06, piman ...
8 years, 6 months ago (2012-06-19 02:49:25 UTC) #4
piman
lgtm
8 years, 6 months ago (2012-06-19 03:05:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/10537128/3001
8 years, 6 months ago (2012-06-19 03:25:02 UTC) #6
commit-bot: I haz the power
Presubmit check for 10537128-3001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-19 03:25:08 UTC) #7
Avi (use Gerrit)
drive by owner lgtm with comment https://chromiumcodereview.appspot.com/10537128/diff/3001/content/renderer/render_widget.cc File content/renderer/render_widget.cc (right): https://chromiumcodereview.appspot.com/10537128/diff/3001/content/renderer/render_widget.cc#newcode118 content/renderer/render_widget.cc:118: if (!CommandLine::ForCurrentProcess()->HasSwitch( I ...
8 years, 6 months ago (2012-06-19 03:33:57 UTC) #8
Ian Vollick
On 2012/06/19 03:33:57, Avi wrote: > drive by owner lgtm with comment > > https://chromiumcodereview.appspot.com/10537128/diff/3001/content/renderer/render_widget.cc ...
8 years, 6 months ago (2012-06-19 12:22:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/10537128/11001
8 years, 6 months ago (2012-06-19 12:22:55 UTC) #10
commit-bot: I haz the power
8 years, 6 months ago (2012-06-19 14:42:16 UTC) #11
Change committed as 142951

Powered by Google App Engine
This is Rietveld 408576698