Allow non integer device scale factors in render widget

Allow non integer device scale factors in render widget

Currently we force device scale factors to integers in render widget preventing us from experimenting with non integer default device scale factors. This patch fixes that.

BUG=None
TEST=Use a default device scale factor of 1.5


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142951

[piman, 2012-06-12 19:21:06]

I think it's ok to experiment, but are we guaranteed that it still has an int
scaling factor where we care about it? Scaling with a non-int factor is really
ugly.

[Ian Vollick, 2012-06-19 02:48:44]

On 2012/06/12 19:21:06, piman wrote:
> I think it's ok to experiment, but are we guaranteed that it still has an int
> scaling factor where we care about it? Scaling with a non-int factor is really
> ugly.
It's true :) I've updated the code so that we only use non-integer scale factors
if the user has explicitly used the --force-device-scale-factor flag. Does this
seem any better?

[Ian Vollick, 2012-06-19 02:49:25]

+rbyers
(Sorry for the spam).

On 2012/06/19 02:48:44, vollick wrote:
> On 2012/06/12 19:21:06, piman wrote:
> > I think it's ok to experiment, but are we guaranteed that it still has an
int
> > scaling factor where we care about it? Scaling with a non-int factor is
really
> > ugly.
> It's true :) I've updated the code so that we only use non-integer scale
factors
> if the user has explicitly used the --force-device-scale-factor flag. Does
this
> seem any better?

[piman, 2012-06-19 03:05:20]

lgtm

[commit-bot: I haz the power, 2012-06-19 03:25:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/10537128/3001

[commit-bot: I haz the power, 2012-06-19 03:25:08]

Presubmit check for 10537128-3001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/browser/renderer_host

Presubmit checks took 4.2s to calculate.

[Avi (use Gerrit), 2012-06-19 03:33:57]

drive by owner lgtm with comment

https://chromiumcodereview.appspot.com/10537128/diff/3001/content/renderer/re...
File content/renderer/render_widget.cc (right):

https://chromiumcodereview.appspot.com/10537128/diff/3001/content/renderer/re...
content/renderer/render_widget.cc:118: if
(!CommandLine::ForCurrentProcess()->HasSwitch(
I think a comment is worthwhile here. Something like "// Unless an explicit
scale factor was provided for testing, ensure the scale is integral" or the
like. It took me a few reads of the code to understand what was going on here.

[Ian Vollick, 2012-06-19 12:22:46]

On 2012/06/19 03:33:57, Avi wrote:
> drive by owner lgtm with comment
> 
>
https://chromiumcodereview.appspot.com/10537128/diff/3001/content/renderer/re...
> File content/renderer/render_widget.cc (right):
> 
>
https://chromiumcodereview.appspot.com/10537128/diff/3001/content/renderer/re...
> content/renderer/render_widget.cc:118: if
> (!CommandLine::ForCurrentProcess()->HasSwitch(
> I think a comment is worthwhile here. Something like "// Unless an explicit
> scale factor was provided for testing, ensure the scale is integral" or the
> like. It took me a few reads of the code to understand what was going on here.

Done.

[commit-bot: I haz the power, 2012-06-19 12:22:55]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/vollick@chromium.org/10537128/11001

[commit-bot: I haz the power, 2012-06-19 14:42:16]

Change committed as 142951