Issue 10537057: refactor VideoCaptureHost and VideoCaptureController.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10537057: refactor VideoCaptureHost and VideoCaptureController. (Closed)

Created:
8 years, 6 months ago by wjia(left Chromium)

Modified:
8 years, 6 months ago

Reviewers:
mflodman_chromium_OOO

CC:
chromium-reviews, joi+watch-content_chromium.org, feature-media-reviews_chromium.org, jam, jochen+watch-content_chromium.org, darin-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

refactor VideoCaptureHost and VideoCaptureController. Change API of StopCapture() between VCH and VCC to simplify the states of VCH. This also helps to remove some racing condition which leads to calling StopCapture() twice when channel is closed. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141500

Patch Set 1 #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+131 lines, -206 lines)			Patch
M	content/browser/renderer_host/media/video_capture_controller.h	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/media/video_capture_controller.cc	View	7 chunks	+28 lines, -61 lines	0 comments	Download
M	content/browser/renderer_host/media/video_capture_controller_event_handler.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	content/browser/renderer_host/media/video_capture_controller_unittest.cc	View	4 chunks	+4 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/media/video_capture_host.h	View	2 chunks	+20 lines, -21 lines	0 comments	Download
M	content/browser/renderer_host/media/video_capture_host.cc	View	7 chunks	+76 lines, -110 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

mflodman_chromium_OOO

8 years, 6 months ago (2012-06-11 18:23:52 UTC) #2

LGTM

Nice cleanup and nice to get rid of the states in VideoCaptureHost::Entry!

Expand Messages | Collapse Messages