Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: content/browser/renderer_host/media/video_capture_host.h

Issue 10537057: refactor VideoCaptureHost and VideoCaptureController. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/media/video_capture_host.h
===================================================================
--- content/browser/renderer_host/media/video_capture_host.h (revision 141042)
+++ content/browser/renderer_host/media/video_capture_host.h (working copy)
@@ -79,7 +79,6 @@
int height,
int frame_per_second) OVERRIDE;
virtual void OnPaused(const VideoCaptureControllerID& id) OVERRIDE;
- virtual void OnReadyToDelete(const VideoCaptureControllerID& id) OVERRIDE;
private:
friend class content::BrowserThread;
@@ -112,35 +111,35 @@
// referenced by |device_id|.
void OnReceiveEmptyBuffer(int device_id, int buffer_id);
-
- // Called on the IO thread when VideoCaptureController have
- // reported that all DIBs have been returned.
- void DoDeleteVideoCaptureControllerOnIOThread(
- const VideoCaptureControllerID& id);
-
// Send a newly created buffer to the VideoCaptureMessageFilter.
- void DoSendNewBufferOnIOThread(int device_id,
- base::SharedMemoryHandle handle,
- int length,
- int buffer_id);
+ void DoSendNewBufferOnIOThread(
+ const VideoCaptureControllerID& controller_id,
+ base::SharedMemoryHandle handle,
+ int length,
+ int buffer_id);
// Send a filled buffer to the VideoCaptureMessageFilter.
- void DoSendFilledBufferOnIOThread(int device_id,
- int buffer_id,
- base::Time timestamp);
+ void DoSendFilledBufferOnIOThread(
+ const VideoCaptureControllerID& controller_id,
+ int buffer_id,
+ base::Time timestamp);
- // Send a information about frame resolution and frame rate
+ // Send information about frame resolution and frame rate
// to the VideoCaptureMessageFilter.
- void DoSendFrameInfoOnIOThread(int device_id,
- int width,
- int height,
- int frame_per_second);
+ void DoSendFrameInfoOnIOThread(
+ const VideoCaptureControllerID& controller_id,
+ int width,
+ int height,
+ int frame_per_second);
// Handle error coming from VideoCaptureDevice.
- void DoHandleErrorOnIOThread(int device_id);
+ void DoHandleErrorOnIOThread(const VideoCaptureControllerID& controller_id);
- void DoPausedOnIOThread(int device_id);
+ void DoPausedOnIOThread(const VideoCaptureControllerID& controller_id);
+ void DeleteVideoCaptureControllerOnIOThread(
+ const VideoCaptureControllerID& controller_id);
+
// Helpers.
media_stream::VideoCaptureManager* GetVideoCaptureManager();

Powered by Google App Engine
This is Rietveld 408576698