Fix a bunch of implicit casts detected by the Win64 compiler

Fix a bunch of implicit casts detected by the Win64 compiler

Committed: https://code.google.com/p/v8/source/detail?r=11862

[Jakob Kummerow, 2012-06-19 12:40:50]

Working on getting our Win64 bot up and running again, I found a bunch of
implicit casts (size_t -> int and so on) that have accumulated over the past few
weeks. Please take a look whether these point towards any unintentional
precision losses or signedness problems.

I inserted those casts in a pretty mechanical fashion; if you have ideas for
cleaner fixes they are most welcome.

Reviewers (based on who touched the affected lines last):

Yang: please look at
preparser/preparser-process.cc
src/assembler.cc
src/debug.cc
and while you haven't changed them, could you also review the following please?
samples/process.cc
samples/shell.cc

Peter:
samples/lineprocessor.cc

Andreas:
src/d8.cc

Erik:
src/factory.cc

Sanjoy:
src/zone-inl.h

[Erik Corry, 2012-06-19 12:43:04]

https://chromiumcodereview.appspot.com/10536202/diff/1/src/factory.cc
File src/factory.cc (right):

https://chromiumcodereview.appspot.com/10536202/diff/1/src/factory.cc#newcode728
src/factory.cc:728: Vector<char> v2(p, static_cast<int>(space));
LGTM

[sanjoy, 2012-06-19 12:45:56]

https://chromiumcodereview.appspot.com/10536202/diff/1/src/zone-inl.h
File src/zone-inl.h (right):

https://chromiumcodereview.appspot.com/10536202/diff/1/src/zone-inl.h#newcode103
src/zone-inl.h:103: return zone_->New(static_cast<int>(size));
LGTM.

[Peter Rybin, 2012-06-19 12:49:26]

I can only say for lineprocessor.cc — LGTM

[Yang, 2012-06-19 12:50:19]

On 2012/06/19 12:45:56, sanjoy wrote:
> https://chromiumcodereview.appspot.com/10536202/diff/1/src/zone-inl.h
> File src/zone-inl.h (right):
> 
>
https://chromiumcodereview.appspot.com/10536202/diff/1/src/zone-inl.h#newcode103
> src/zone-inl.h:103: return zone_->New(static_cast<int>(size));
> LGTM.

LGTM. You just changed so little, and this is crazy, but copyright headers are
outdated, so update them, maybe?

[rossberg, 2012-06-19 13:35:30]

https://chromiumcodereview.appspot.com/10536202/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/10536202/diff/1/src/d8.cc#newcode289
src/d8.cc:289: return value_in->Uint32Value();
You probably need a static_cast here now, because Uint32Value returns uint32_t.

https://chromiumcodereview.appspot.com/10536202/diff/1/src/d8.cc#newcode315
src/d8.cc:315: return static_cast<int32_t>(raw_value);
You can remove this cast altogether.

[Jakob Kummerow, 2012-06-19 13:44:08]

Copyright years updated and comments addressed.

https://chromiumcodereview.appspot.com/10536202/diff/1/src/d8.cc
File src/d8.cc (right):

https://chromiumcodereview.appspot.com/10536202/diff/1/src/d8.cc#newcode289
src/d8.cc:289: return value_in->Uint32Value();
On 2012/06/19 13:35:30, rossberg wrote:
> You probably need a static_cast here now, because Uint32Value returns
uint32_t.

Done.

https://chromiumcodereview.appspot.com/10536202/diff/1/src/d8.cc#newcode315
src/d8.cc:315: return static_cast<int32_t>(raw_value);
On 2012/06/19 13:35:30, rossberg wrote:
> You can remove this cast altogether.

Done.

[rossberg, 2012-06-19 13:45:03]

lgtm