src/factory.cc - Issue 10536202: Fix a bunch of implicit casts detected by the Win64 compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 10536202: Fix a bunch of implicit casts detected by the Win64 compiler (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: fixed casts in d8.cc, updated copyright years Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index bdf93b92a100fbdcf2c565963333f8cd8b98f153..682125e3af5f90ae53d284f4cad85f36238cb015 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -725,7 +725,7 @@ Handle<String> Factory::EmergencyNewError(const char* type,

MaybeObject* maybe_arg = args->GetElement(i);

Handle<String> arg_str(reinterpret_cast<String*>(maybe_arg));

const char* arg = *arg_str->ToCString();

- Vector<char> v2(p, space);

+ Vector<char> v2(p, static_cast<int>(space));

OS::StrNCpy(v2, arg, space);

space -= Min(space, strlen(arg));

p = &buffer[kBufferSize] - space;

« no previous file with comments | « src/debug.cc ('k') | src/zone-inl.h » ('j') | no next file with comments »