Plumb rendering statistics to benchmarking extension.

Plumb rendering statistics to benchmarking extension.


BUG=chromium:130130
TEST=Start Chrome with --enable-benchmarking --enable-stats-table. Open a page that uses hardware compositing, like poster circle. Open Javascript console and type in chrome.benchmarking.renderingStats(). The numbers should be reasonable. Do the same with a page that uses software compositing. It should return an empty Object, and it should not crash.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=145253

[nduca, 2012-06-15 00:26:21]

http://codereview.chromium.org/10536080/diff/3002/chrome/renderer/benchmarkin...
File chrome/renderer/benchmarking_extension.cc (right):

http://codereview.chromium.org/10536080/diff/3002/chrome/renderer/benchmarkin...
chrome/renderer/benchmarking_extension.cc:67: "  native function
RenderingStats();"
We want to move these changes to gpu_benchmarking_extension

http://codereview.chromium.org/10536080/diff/3002/chrome/renderer/benchmarkin...
chrome/renderer/benchmarking_extension.cc:194: 
/me wonders if there's a way to get the fields of this struct into a v8 object
without having  to edit chrome. Any ideas? Maybe james or nate chapin (@japhet)
have some ideas... i think it would be nice to be able to add metrics without
having to make an edit to chrome each time we do it.

http://codereview.chromium.org/10536080/diff/3002/content/renderer/render_vie...
File content/renderer/render_view_impl.h (left):

http://codereview.chromium.org/10536080/diff/3002/content/renderer/render_vie...
content/renderer/render_view_impl.h:689: 
Once they're moved to the gpu benchmarking extension, we can make direct calls
to RenderWidget and RenderViewImpl/RenderView can be unchanged.

[nduca, 2012-06-15 01:57:42]

http://codereview.chromium.org/10536080/diff/3002/content/renderer/render_wid...
File content/renderer/render_widget.cc (right):

http://codereview.chromium.org/10536080/diff/3002/content/renderer/render_wid...
content/renderer/render_widget.cc:1703: webwidget()->renderingStats(stats);
you need to check here if you're in software mode
(!is_accelerated_compositing_active_), and if so, you need to use the number of
DoDeferredUpdate calls that ran to completion for numFramesSentToScreen.
Similarly, you need to track the number of times we call webwidget()->animate
[the top of doDeferredUpdate) in software mode, and return that for
animationFrameCount.

[dtu, 2012-06-20 00:57:32]

https://chromiumcodereview.appspot.com/10536080/diff/3002/chrome/renderer/ben...
File chrome/renderer/benchmarking_extension.cc (right):

https://chromiumcodereview.appspot.com/10536080/diff/3002/chrome/renderer/ben...
chrome/renderer/benchmarking_extension.cc:67: "  native function
RenderingStats();"
On 2012/06/15 00:26:22, nduca wrote:
> We want to move these changes to gpu_benchmarking_extension

Done.

https://chromiumcodereview.appspot.com/10536080/diff/3002/content/renderer/re...
File content/renderer/render_view_impl.h (left):

https://chromiumcodereview.appspot.com/10536080/diff/3002/content/renderer/re...
content/renderer/render_view_impl.h:689: 
On 2012/06/15 00:26:22, nduca wrote:
> Once they're moved to the gpu benchmarking extension, we can make direct calls
> to RenderWidget and RenderViewImpl/RenderView can be unchanged.

Done.

https://chromiumcodereview.appspot.com/10536080/diff/3002/content/renderer/re...
File content/renderer/render_widget.cc (right):

https://chromiumcodereview.appspot.com/10536080/diff/3002/content/renderer/re...
content/renderer/render_widget.cc:1703: webwidget()->renderingStats(stats);
Now we have renderingStats() in WebView instead of WebWidget. Does this still
apply?

On 2012/06/15 01:57:42, nduca wrote:
> you need to check here if you're in software mode
> (!is_accelerated_compositing_active_), and if so, you need to use the number
of
> DoDeferredUpdate calls that ran to completion for numFramesSentToScreen.
> Similarly, you need to track the number of times we call webwidget()->animate
> [the top of doDeferredUpdate) in software mode, and return that for
> animationFrameCount.

[dtu, 2012-06-22 20:19:01]

+jamesr for OWNERS. This is the Chromium side of wkbug.com/88268

[jamesr, 2012-06-22 20:21:59]

lgtm

[commit-bot: I haz the power, 2012-07-02 20:53:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/10536080/23001

[commit-bot: I haz the power, 2012-07-02 23:14:21]

Try job failure for 10536080-23001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-07-03 03:04:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dtu@chromium.org/10536080/23001

[commit-bot: I haz the power, 2012-07-03 04:28:06]

Change committed as 145253