Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10536034: Fix logic reversal bug in TraceMessageFilter (Closed)

Created:
8 years, 6 months ago by jbates
Modified:
8 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews
Visibility:
Public.

Description

Fix logic reversal bug in TraceMessageFilter. BUG=131326 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141234

Patch Set 1 #

Patch Set 2 : rename bool to avoid confusion #

Total comments: 2

Patch Set 3 : sky feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M content/browser/trace_message_filter.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/trace_message_filter.cc View 1 2 5 chunks +11 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbates
8 years, 6 months ago (2012-06-06 18:12:10 UTC) #1
sky
https://chromiumcodereview.appspot.com/10536034/diff/2001/content/browser/trace_message_filter.cc File content/browser/trace_message_filter.cc (right): https://chromiumcodereview.appspot.com/10536034/diff/2001/content/browser/trace_message_filter.cc#newcode92 content/browser/trace_message_filter.cc:92: DCHECK(is_awaiting_end_ack_); How about an else NOTREACHED instead. Or, remove ...
8 years, 6 months ago (2012-06-06 20:16:32 UTC) #2
jbates
https://chromiumcodereview.appspot.com/10536034/diff/2001/content/browser/trace_message_filter.cc File content/browser/trace_message_filter.cc (right): https://chromiumcodereview.appspot.com/10536034/diff/2001/content/browser/trace_message_filter.cc#newcode92 content/browser/trace_message_filter.cc:92: DCHECK(is_awaiting_end_ack_); On 2012/06/06 20:16:32, sky wrote: > How about ...
8 years, 6 months ago (2012-06-06 21:22:16 UTC) #3
sky
Ya, sorry, LGTM
8 years, 6 months ago (2012-06-08 02:53:07 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbates@chromium.org/10536034/5002
8 years, 6 months ago (2012-06-08 15:43:52 UTC) #5
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 17:49:34 UTC) #6 
Change committed as 141234

Powered by Google App Engine
This is Rietveld 408576698