content/browser/trace_message_filter.h - Issue 10536034: Fix logic reversal bug in TraceMessageFilter

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: content/browser/trace_message_filter.h

Issue 10536034: Fix logic reversal bug in TraceMessageFilter (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sky feedback Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef CONTENT_BROWSER_TRACE_MESSAGE_FILTER_H_	5 #ifndef CONTENT_BROWSER_TRACE_MESSAGE_FILTER_H_

6 #define CONTENT_BROWSER_TRACE_MESSAGE_FILTER_H_	6 #define CONTENT_BROWSER_TRACE_MESSAGE_FILTER_H_

7	7

8 #include <string>	8 #include <string>

9 #include <vector>	9 #include <vector>

10	10

(...skipping 28 matching lines...) Expand all Loading...
39 void OnEndTracingAck(const std::vector<std::string>& known_categories);	39 void OnEndTracingAck(const std::vector<std::string>& known_categories);

40 void OnTraceBufferFull();	40 void OnTraceBufferFull();

41 void OnTraceBufferPercentFullReply(float percent_full);	41 void OnTraceBufferPercentFullReply(float percent_full);

42 void OnTraceDataCollected(const std::string& data);	42 void OnTraceDataCollected(const std::string& data);

43	43

44 // ChildTraceMessageFilter exists:	44 // ChildTraceMessageFilter exists:

45 bool has_child_;	45 bool has_child_;

46	46

47 // Awaiting ack for previously sent SendEndTracing	47 // Awaiting ack for previously sent SendEndTracing

48 bool is_awaiting_end_ack_;	48 bool is_awaiting_end_ack_;

49 bool is_awaiting_bpf_ack_;	49 // Awaiting ack for previously sent SendGetTraceBufferPercentFull

	50 bool is_awaiting_buffer_percent_full_ack_;

50	51

51 DISALLOW_COPY_AND_ASSIGN(TraceMessageFilter);	52 DISALLOW_COPY_AND_ASSIGN(TraceMessageFilter);

52 };	53 };

53	54

54 #endif // CONTENT_BROWSER_TRACE_MESSAGE_FILTER_H_	55 #endif // CONTENT_BROWSER_TRACE_MESSAGE_FILTER_H_

55	56

OLD	NEW

« no previous file with comments | « no previous file | content/browser/trace_message_filter.cc » ('j') | no next file with comments »