Ignore simulated mouse move messages.

Ignore simulated mouse move messages.


BUG=129638
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=142757

[girard, 2012-06-12 15:35:02]

We didn't ignore WM_MOUSEMOVE events that are generated by the OS on a touch
event.

[girard, 2012-06-12 15:36:12]

+sky, rjkroege
We ignored all emulated mouse events, except for WM_MOUSEMOVE.  We now ignore
that one too.

[rjkroege, 2012-06-12 15:38:09]

lgtm

[commit-bot: I haz the power, 2012-06-12 15:50:38]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[sky, 2012-06-12 16:51:51]

https://chromiumcodereview.appspot.com/10535131/diff/1/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_win.cc (right):

https://chromiumcodereview.appspot.com/10535131/diff/1/content/browser/render...
content/browser/renderer_host/render_widget_host_view_win.cc:1804: if
(touch_events_enabled_ && (message == WM_MOUSEMOVE ||
The msdn docs this comes from mention it not working for mousemove and I wasn't
seeing consistent behavior when testing this. Are you sure it works ok on both
win7 and win8 with various hardware?

[girard, 2012-06-15 13:57:28]

Still need to test on Win7 touch.  Will do so on June 18.

https://chromiumcodereview.appspot.com/10535131/diff/1/content/browser/render...
File content/browser/renderer_host/render_widget_host_view_win.cc (right):

https://chromiumcodereview.appspot.com/10535131/diff/1/content/browser/render...
content/browser/renderer_host/render_widget_host_view_win.cc:1804: if
(touch_events_enabled_ && (message == WM_MOUSEMOVE ||
On 2012/06/12 16:51:51, sky wrote:
> The msdn docs this comes from mention it not working for mousemove and I
wasn't
> seeing consistent behavior when testing this. Are you sure it works ok on both
> win7 and win8 with various hardware?

Tested on Win8.  Will test on Win7 on Monday.

[girard, 2012-06-18 15:49:07]

On 2012/06/15 13:57:28, girard wrote:
> Still need to test on Win7 touch.  Will do so on June 18.
> 

Win8 seems to work perfectly with this patch.  Touching the screen does not fire
any touch events, unless you tap the screen (which generates a mouse messages as
per the spec.)

Win7 _mostly_ works.  The OS generates a lot of mouse messages, and most of them
are ignored by chrome, except:
 (1) when the user first touches an inactive window, a WM_MOUSEOVER and
WM_MOUSEMOVE are fired by the OS, without any flags.  This is presumably sent to
activate the window.  We have no means to identify that these are touches.
 (2) when a user starts touching an active window, a WM_MOUSEMOVE is sent at the
initial touch location without flags.  Subsequent move messages get flagged. 
Thus we get one "unflagged" mouse event for each touch.

We could possibly add some logic under Win7 to identify these simulated mouse
messages.  We could test to see if the WM_MOUSEMOVE is near a previous mouse
move, we could watch for WM_MOUSEOVER messages that are not at the edge of the
window, we could wait for a second mousemove before we send the message on.... 
In all of these cases, I expect that we'd be introducing some fairly complex and
flakey code, and so I recommend against this kind of kludge.

[sky, 2012-06-18 16:57:15]

LGTM

[commit-bot: I haz the power, 2012-06-18 17:17:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/girard@chromium.org/10535131/1

[commit-bot: I haz the power, 2012-06-18 18:13:58]

Change committed as 142757