Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 10535117: Revert 141476 - Do not stop audio physical stream immediately after logical one had stopped. (Closed)

Created:
8 years, 6 months ago by sail
Modified:
8 years, 6 months ago
Reviewers:
enal
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Revert 141476 - Do not stop audio physical stream immediately after logical one had stopped. Wait some time. We are still stopping/closing the stream, as (1) it is better for battery life, and (2) some people can hear active device even when it is playing silence. That increased audio startup latency, especially on Windows, because we are using 3 buffers on Windows. To fix that I changed the code to use 2 buffers on presumable good Windows boxes -- i.e. running non-Vista and having more than single core. Changed unit tests as well. BUG=129190 TEST=Should not be noticeable difference in behavior. Run tests on Win7 and XP myself. Review URL: https://chromiumcodereview.appspot.com/10540034 TBR=enal@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141505

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -70 lines) Patch
M media/audio/audio_output_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/audio_output_mixer.cc View 3 chunks +34 lines, -16 lines 0 comments Download
M media/audio/audio_util.h View 1 chunk +0 lines, -3 lines 0 comments Download
M media/audio/audio_util.cc View 2 chunks +0 lines, -15 lines 0 comments Download
M media/audio/win/audio_manager_win.cc View 1 chunk +1 line, -4 lines 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 6 chunks +22 lines, -31 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
sail
8 years, 6 months ago (2012-06-11 21:21:55 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698