/C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e…

remoting/base/breakpad.h

Index: remoting/base/breakpad.h
diff --git a/remoting/base/breakpad.h b/remoting/base/breakpad.h
new file mode 100644
index 0000000000000000000000000000000000000000..7e1f0a40ea92c7f9efb60608846d1cf20b3eaa2a
--- /dev/null
+++ b/remoting/base/breakpad.h
@@ -0,0 +1,23 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef REMOTING_BASE_BREAKPAD_H_
+#define REMOTING_BASE_BREAKPAD_H_
+
+namespace remoting {
+
+// Initializes collection and upload of crash reports. The caller has to ensure
+// that the user has agreed to crash dump reporting.
+//
+// Crash reporting has to be initialized as early as possible (e.g. the first
+// thing in main()) to catch crashes occured during the process startup.

[Peter Kasting, 2012/06/14 20:16:27]

Nit: s/occured/occurring/ ; s/the//

[alexeypa (please no reviews), 2012/06/15 18:45:49]

Done.

+// The crashes occurred while invoking the static objects' constructors will not

[Peter Kasting, 2012/06/14 20:16:27]

Nit: How about "Crashes which occur during the global static construction phase
will not..."

[alexeypa (please no reviews), 2012/06/15 18:45:49]

Yes. This sounds better.

+// be caught and reported. This should not be a problem as the static non POD

[Peter Kasting, 2012/06/14 20:16:27]

Nit: s/the// ; s/non POD/non-POD/

[alexeypa (please no reviews), 2012/06/15 18:45:49]

Done.

+// objects are not allowed by the style guide and exceptions to this rule are
+// rare.
+void InitializeCrashReporting();
+
+}  // remoting
+
+#endif  // REMOTING_BASE_BREAKPAD_H_