remoting/base/breakpad.h - Issue 10535082: /C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/base/breakpad.h

Issue 10535082: /C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef REMOTING_BASE_BREAKPAD_H_

	6 #define REMOTING_BASE_BREAKPAD_H_

	7

	8 namespace remoting {

	9

	10 // Initializes collection and upload of crash reports. The caller has to ensure

	11 // that the user has agreed to crash dump reporting.

	12 //

	13 // Crash reporting has to be initialized as early as possible (e.g. the first

	14 // thing in main()) to catch crashes occured during the process startup.
	Peter Kasting 2012/06/14 20:16:27 Nit: s/occured/occurring/ ; s/the// Nit: s/occured/occurring/ ; s/the// alexeypa (please no reviews) 2012/06/15 18:45:49 Done. Show quoted text On 2012/06/14 20:16:27, Peter Kasting wrote: > Nit: s/occured/occurring/ ; s/the// Done.
	15 // The crashes occurred while invoking the static objects' constructors will not
	Peter Kasting 2012/06/14 20:16:27 Nit: How about "Crashes which occur during the glo Nit: How about "Crashes which occur during the global static construction phase will not..." alexeypa (please no reviews) 2012/06/15 18:45:49 Yes. This sounds better. Show quoted text On 2012/06/14 20:16:27, Peter Kasting wrote: > Nit: How about "Crashes which occur during the global static construction phase > will not..." Yes. This sounds better.
	16 // be caught and reported. This should not be a problem as the static non POD
	Peter Kasting 2012/06/14 20:16:27 Nit: s/the// ; s/non POD/non-POD/ Nit: s/the// ; s/non POD/non-POD/ alexeypa (please no reviews) 2012/06/15 18:45:49 Done. Show quoted text On 2012/06/14 20:16:27, Peter Kasting wrote: > Nit: s/the// ; s/non POD/non-POD/ Done.
	17 // objects are not allowed by the style guide and exceptions to this rule are

	18 // rare.

	19 void InitializeCrashReporting();

	20

	21 } // remoting

	22

	23 #endif // REMOTING_BASE_BREAKPAD_H_

OLD	NEW

« no previous file with comments | « remoting/base/DEPS ('k') | remoting/base/breakpad_linux.cc » ('j') | remoting/base/breakpad_linux.cc » ('J')