/C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e…

remoting/host/constants_win.cc

Index: remoting/host/constants_win.cc
diff --git a/remoting/host/constants_win.cc b/remoting/host/constants_win.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e13ce811b05b29d753648775bb2acb374b2945c4
--- /dev/null
+++ b/remoting/host/constants_win.cc
@@ -0,0 +1,21 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/host/constants.h"
+
+#include "base/stringize_macros.h"
+
+namespace remoting {
+
+#if defined(OS_WIN)

[Peter Kasting, 2012/06/14 20:16:27]

Is this directive needed?  This is already a _win.cc file.

[alexeypa (please no reviews), 2012/06/15 18:45:49]

Done.

+
+// The Omaha Appid of the host. It should be kept in sync with $(var.OmahaAppid)
+// defined in remoting/host/installer/chromoting.wxs and the Omaha server
+// configuration.
+const char16 kHostOmahaAppid[] =
+    TO_L_STRING("{b210701e-ffc4-49e3-932b-370728c72662}");

[Peter Kasting, 2012/06/14 20:16:27]

Just use L directly here, rather than TO_L_STRING, whose main utility is
stringizing preprocessor directives.

[alexeypa (please no reviews), 2012/06/15 18:45:49]

Done.

+
+#endif  // defined(OS_WIN)
+
+}  // namespace remoting