remoting/host/constants_win.cc - Issue 10535082: /C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e…

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: remoting/host/constants_win.cc

Issue 10535082: /C++ readability/ - Make Chromoting Host report crashes to Breakpad (Windows only). The user must e… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "remoting/host/constants.h"

	6

	7 #include "base/stringize_macros.h"

	8

	9 namespace remoting {

	10

	11 #if defined(OS_WIN)
	Peter Kasting 2012/06/14 20:16:27 Is this directive needed? This is already a _win. Is this directive needed? This is already a _win.cc file. alexeypa (please no reviews) 2012/06/15 18:45:49 Done. Show quoted text On 2012/06/14 20:16:27, Peter Kasting wrote: > Is this directive needed? This is already a _win.cc file. Done.
	12

	13 // The Omaha Appid of the host. It should be kept in sync with $(var.OmahaAppid)

	14 // defined in remoting/host/installer/chromoting.wxs and the Omaha server

	15 // configuration.

	16 const char16 kHostOmahaAppid[] =

	17 TO_L_STRING("{b210701e-ffc4-49e3-932b-370728c72662}");
	Peter Kasting 2012/06/14 20:16:27 Just use L directly here, rather than TO_L_STRING, Just use L directly here, rather than TO_L_STRING, whose main utility is stringizing preprocessor directives. alexeypa (please no reviews) 2012/06/15 18:45:49 Done. Show quoted text On 2012/06/14 20:16:27, Peter Kasting wrote: > Just use L directly here, rather than TO_L_STRING, whose main utility is > stringizing preprocessor directives. Done.
	18

	19 #endif // defined(OS_WIN)

	20

	21 } // namespace remoting

OLD	NEW

« remoting/host/constants.h ('K') | « remoting/host/constants.h ('k') | remoting/host/elevated_controller_module_win.cc » ('j') | remoting/host/elevated_controller_module_win.cc » ('J')