Issue 10535081: Fixed a bug in the WaitUntilNavigationCompletes automation command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10535081: Fixed a bug in the WaitUntilNavigationCompletes automation command. (Closed)

Created:
8 years, 6 months ago by craigdh

Modified:
8 years, 6 months ago

Reviewers:
dennis_jeffrey

CC:
chromium-reviews, robertshield, kkania, Nirnimesh

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixed a bug in the WaitUntilNavigationCompletes automation command. Previously the hook would try to use reply_message, despite it being owned by a scoped_ptr in the NavigationNotificationObserver. This resulted in a segfault when the page was already loaded, as the scoped_ptr was deleting the object when the observer was deleted. BUG=None TEST=functional/apptest.py Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141278

Patch Set 1 #

Patch Set 2 : Rebase. #

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/browser/automation/automation_provider_observers.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/automation/testing_automation_provider.cc	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/craigdh@chromium.org/10535081/3001

8 years, 6 months ago (2012-06-08 19:18:37 UTC) #3

Change committed as 141278

Expand Messages | Collapse Messages