Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: chrome/browser/automation/testing_automation_provider.cc

Issue 10535081: Fixed a bug in the WaitUntilNavigationCompletes automation command. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/automation/automation_provider_observers.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/testing_automation_provider.cc
diff --git a/chrome/browser/automation/testing_automation_provider.cc b/chrome/browser/automation/testing_automation_provider.cc
index 34313445fe8243d641a4d29e0893e33722161b52..3b8881a8a33b51d15bd4e4693e016249e4c208b8 100644
--- a/chrome/browser/automation/testing_automation_provider.cc
+++ b/chrome/browser/automation/testing_automation_provider.cc
@@ -6088,8 +6088,7 @@ void TestingAutomationProvider::WaitUntilNavigationCompletes(
new NavigationNotificationObserver(&web_contents->GetController(), this,
reply_message, 1, true, true);
if (!web_contents->IsLoading()) {
- AutomationJSONReply(this, reply_message).SendSuccess(NULL);
- delete observer;
+ observer->ConditionMet(AUTOMATION_MSG_NAVIGATION_SUCCESS);
return;
}
}
« no previous file with comments | « chrome/browser/automation/automation_provider_observers.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698