Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Issue 10535059: Remove -F…ApplicationServices.framework/Frameworks (Closed)

Created:
8 years, 6 months ago by Mark Mentovai
Modified:
8 years, 6 months ago
CC:
chromium-reviews, erikwright (departed), brettw-cc_chromium.org
Visibility:
Public.

Description

Remove -F$(SDKROOT)/System/Library/Frameworks/ApplicationServices.framework/Frameworks It wasn't ever correct to compile or link with this, and it just encourages people to do stupid things that aren't guaranteed to work at runtime in future OS releases or with future SDKs. Just #include <ApplicationServices/ApplicationServices.h> or link against ApplicationServices.framework by adding $(SDKROOT)/System/Library/Frameworks/ApplicationServices.framework to your 'link_settings': {'libraries': []} section. The WebKit portion was fixed at https://bugs.webkit.org/show_bug.cgi?id=88569 . Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142137

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -14 lines) Patch
M base/base.gypi View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/idle_mac.mm View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M skia/skia.gyp View 1 2 2 chunks +0 lines, -6 lines 0 comments Download
M ui/gfx/rect.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/size.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
8 years, 6 months ago (2012-06-14 04:01:11 UTC) #1
Alexei Svitkine (slow)
LGTM
8 years, 6 months ago (2012-06-14 04:08:25 UTC) #2
Nico
8 years, 6 months ago (2012-06-14 04:08:50 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698