chrome/browser/ui/views/location_bar/page_info_helper.cc - Issue 10534153: Use OmniboxViewViews on Win with --enable-views-textfield.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/page_info_helper.cc

Issue 10534153: Use OmniboxViewViews on Win with --enable-views-textfield. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/page_info_helper.cc

diff --git a/chrome/browser/ui/views/location_bar/page_info_helper.cc b/chrome/browser/ui/views/location_bar/page_info_helper.cc

index 3a6ad5d41c458096af8db0c7823591641809c7c4..b350cd6f60fe698c0d513ef784d5e5a61e1a30ee 100644

--- a/chrome/browser/ui/views/location_bar/page_info_helper.cc

+++ b/chrome/browser/ui/views/location_bar/page_info_helper.cc

@@ -4,6 +4,7 @@

#include "chrome/browser/ui/views/location_bar/page_info_helper.h"

+#include "chrome/browser/ui/omnibox/omnibox_view.h"

oshima 2012/06/14 21:07:04 is this necessary?

msw 2012/06/14 21:30:21 Yes, Line 31's GetLocationEntry()->IsEditingOrEmpt

oshima 2012/06/14 21:41:11 ah i see. thank you for explanation.

#include "chrome/browser/ui/tab_contents/tab_contents.h"

#include "chrome/browser/ui/views/location_bar/location_bar_view.h"

#include "content/public/browser/navigation_controller.h"