Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: chrome/browser/ui/views/location_bar/page_info_helper.cc

Issue 10534153: Use OmniboxViewViews on Win with --enable-views-textfield. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/location_bar/page_info_helper.h" 5 #include "chrome/browser/ui/views/location_bar/page_info_helper.h"
6 6
7 #include "chrome/browser/ui/omnibox/omnibox_view.h"
oshima 2012/06/14 21:07:04 is this necessary?
msw 2012/06/14 21:30:21 Yes, Line 31's GetLocationEntry()->IsEditingOrEmpt
oshima 2012/06/14 21:41:11 ah i see. thank you for explanation.
7 #include "chrome/browser/ui/tab_contents/tab_contents.h" 8 #include "chrome/browser/ui/tab_contents/tab_contents.h"
8 #include "chrome/browser/ui/views/location_bar/location_bar_view.h" 9 #include "chrome/browser/ui/views/location_bar/location_bar_view.h"
9 #include "content/public/browser/navigation_controller.h" 10 #include "content/public/browser/navigation_controller.h"
10 #include "content/public/browser/navigation_entry.h" 11 #include "content/public/browser/navigation_entry.h"
11 #include "content/public/browser/web_contents.h" 12 #include "content/public/browser/web_contents.h"
12 #include "ui/views/view.h" 13 #include "ui/views/view.h"
13 14
14 using content::NavigationController; 15 using content::NavigationController;
15 using content::NavigationEntry; 16 using content::NavigationEntry;
16 using content::WebContents; 17 using content::WebContents;
(...skipping 17 matching lines...) Expand all
34 const NavigationController& controller = tab->GetController(); 35 const NavigationController& controller = tab->GetController();
35 NavigationEntry* nav_entry = controller.GetActiveEntry(); 36 NavigationEntry* nav_entry = controller.GetActiveEntry();
36 if (!nav_entry) { 37 if (!nav_entry) {
37 NOTREACHED(); 38 NOTREACHED();
38 return; 39 return;
39 } 40 }
40 41
41 location_bar_->delegate()->ShowPageInfo( 42 location_bar_->delegate()->ShowPageInfo(
42 tab, nav_entry->GetURL(), nav_entry->GetSSL(), true); 43 tab, nav_entry->GetURL(), nav_entry->GetSSL(), true);
43 } 44 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698