Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 10534131: RFC: Add common named params to all Element constructors (Closed)

Created:
8 years, 6 months ago by vsm
Modified:
8 years ago
Reviewers:
sethladd, sra, sra1, Jacob
CC:
reviews_dartlang.org, antonm, podivilov, Jennifer Messerly
Visibility:
Public.

Description

RFC: Add common named params to all Element constructors This is one of the options we discussed to streamline element construction. E.g., the following (fairly common pattern): new Element.html('<div class="back-arrow button"></div>'); becomes: new DivElement(classes: ['back-arrow', 'button']); See the test for a few more examples. Improvement?

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+557 lines, -222 lines) Patch
M lib/dom/scripts/systemhtml.py View 2 chunks +7 lines, -1 line 0 comments Download
M lib/html/dartium/html_dartium.dart View 50 chunks +270 lines, -108 lines 0 comments Download
M lib/html/frog/html_frog.dart View 50 chunks +270 lines, -108 lines 0 comments Download
M tests/html/query_test.dart View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
vsm
8 years, 6 months ago (2012-06-13 03:53:11 UTC) #1
sethladd
how about adding a Map attrs as optional catch-all map of other attributes? This is ...
8 years, 6 months ago (2012-06-14 17:25:50 UTC) #2
sethladd
VideoElement should probably have a src named arg. Where is AudioElement?
8 years, 6 months ago (2012-06-14 17:27:45 UTC) #3
sra1
8 years, 6 months ago (2012-06-14 18:02:59 UTC) #4
Our plan of record here is to use method cascades.

I have made a comment on Issue 3640.
http://code.google.com/p/dart/issues/detail?id=3640

Lets take the debate there, and restrict the commentary on the CL to issues of
the code.

Powered by Google App Engine
This is Rietveld 408576698