Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 10534055: [refactor] Rename some constants in net-internals. Mostly just removes a redundant "Log" prefix. (Closed)

Created:
8 years, 6 months ago by eroman
Modified:
8 years, 6 months ago
Reviewers:
mmenke
CC:
chromium-reviews, eroman, arv (Not doing code reviews)
Visibility:
Public.

Description

[refactor] Rename some constants in net-internals. Mostly just removes a redundant "Log" prefix. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141180

Patch Set 1 #

Patch Set 2 : remvoe owners. dunno why it was there... #

Total comments: 3

Patch Set 3 : remove renames affecting log compat #

Patch Set 4 : stop adding OWNERS u POS! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+361 lines, -361 lines) Patch
M chrome/browser/resources/net_internals/log_grouper.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/net_internals/log_util.js View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/net_internals/log_view_painter.js View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/resources/net_internals/main.js View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/resources/net_internals/source_entry.js View 9 chunks +39 lines, -39 lines 0 comments Download
M chrome/browser/resources/net_internals/timeline_data_series.js View 4 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/resources/net_internals/timeline_view.js View 1 chunk +12 lines, -12 lines 0 comments Download
M chrome/test/data/webui/net_internals/log_view_painter.js View 24 chunks +273 lines, -273 lines 0 comments Download
M chrome/test/data/webui/net_internals/net_internals_test.js View 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/data/webui/net_internals/timeline_view.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eroman
I had some OCD while working on the other file, and decided to do some ...
8 years, 6 months ago (2012-06-08 00:00:53 UTC) #1
mmenke
https://chromiumcodereview.appspot.com/10534055/diff/2001/chrome/browser/resources/net_internals/main.js File chrome/browser/resources/net_internals/main.js (right): https://chromiumcodereview.appspot.com/10534055/diff/2001/chrome/browser/resources/net_internals/main.js#newcode250 chrome/browser/resources/net_internals/main.js:250: EventSourceType = Constants.sourceType; This breaks log loading compatibility. https://chromiumcodereview.appspot.com/10534055/diff/2001/chrome/browser/resources/net_internals/main.js#newcode271 ...
8 years, 6 months ago (2012-06-08 00:12:51 UTC) #2
eroman
https://chromiumcodereview.appspot.com/10534055/diff/2001/chrome/browser/resources/net_internals/main.js File chrome/browser/resources/net_internals/main.js (right): https://chromiumcodereview.appspot.com/10534055/diff/2001/chrome/browser/resources/net_internals/main.js#newcode250 chrome/browser/resources/net_internals/main.js:250: EventSourceType = Constants.sourceType; On 2012/06/08 00:12:51, Matt Menke wrote: ...
8 years, 6 months ago (2012-06-08 00:13:29 UTC) #3
eroman
PTAL
8 years, 6 months ago (2012-06-08 00:33:50 UTC) #4
mmenke
LGTM
8 years, 6 months ago (2012-06-08 00:35:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/10534055/2004
8 years, 6 months ago (2012-06-08 05:05:12 UTC) #6
commit-bot: I haz the power
8 years, 6 months ago (2012-06-08 06:11:57 UTC) #7
Change committed as 141180

Powered by Google App Engine
This is Rietveld 408576698