chrome/browser/resources/net_internals/log_util.js - Issue 10534055: [refactor] Rename some constants in net-internals. Mostly just removes a redundant "Log" prefix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/net_internals/log_util.js

Issue 10534055: [refactor] Rename some constants in net-internals. Mostly just removes a redundant "Log" prefix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: stop adding OWNERS u POS! Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/net_internals/log_grouper.js ('k') | chrome/browser/resources/net_internals/log_view_painter.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/net_internals/log_util.js

diff --git a/chrome/browser/resources/net_internals/log_util.js b/chrome/browser/resources/net_internals/log_util.js

index 9bbb052dbf809f8c1a896bf8842ca46f5a205a65..9673d7a558957f636e26feb01a4f0965e6ce5569 100644

--- a/chrome/browser/resources/net_internals/log_util.js

+++ b/chrome/browser/resources/net_internals/log_util.js

@@ -179,9 +179,9 @@ log_util = (function() {

if (typeof event == 'object' &&

typeof event.source == 'object' &&

typeof event.time == 'string' &&

- typeof LogEventTypeNames[event.type] == 'string' &&

- typeof LogSourceTypeNames[event.source.type] == 'string' &&

- getKeyWithValue(LogEventPhase, event.phase) != '?') {

+ typeof EventTypeNames[event.type] == 'string' &&

+ typeof EventSourceTypeNames[event.source.type] == 'string' &&

+ getKeyWithValue(EventPhase, event.phase) != '?') {

if (event.wasPassivelyCaptured) {

// NOTE: Up until Chrome 18, log dumps included "passively captured"

// events. These are no longer supported, so skip past them