Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Issue 10534054: Improve extension api tests: run all tests, even if one fails (Closed)

Created:
8 years, 6 months ago by Evan Stade
Modified:
8 years, 6 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Improve extension api tests: run all tests, even if one fails Currently, if a single file has multiple tests, a single failure will abort running the rest of the tests. There's still no way to expect rather than assert, but I plan to add that next. BUG=none TEST=the tests all continue to pass, but if you edit one to make it fail, runAllTests will continue running later tests. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141681

Patch Set 1 #

Patch Set 2 : don't fix indent yet #

Patch Set 3 : . #

Patch Set 4 : fix some tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -77 lines) Patch
M chrome/renderer/resources/extensions/apitest.js View 1 2 3 6 chunks +53 lines, -60 lines 0 comments Download
M chrome/test/data/extensions/api_test/content_security_policy/test.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/background_page/test.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/content_script/test.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/file_access/test.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/cross_origin_xhr/no_file_access/test.js View 1 2 3 1 chunk +6 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/default_content_security_policy/test.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/executescript/permissions/test.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/permissions/favicon/test.js View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/api_test/tabs/get_current/test.js View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/data/extensions/platform_apps/restrictions/test.js View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Evan Stade
not sure who the best reviewer is for this file. I noticed another issue which ...
8 years, 6 months ago (2012-06-07 23:42:30 UTC) #1
Evan Stade
this has broken some tests... hold off on reviewing till I fix it.
8 years, 6 months ago (2012-06-08 02:19:05 UTC) #2
Evan Stade
ok, please review.
8 years, 6 months ago (2012-06-12 00:12:04 UTC) #3
Aaron Boodman
8 years, 6 months ago (2012-06-12 04:10:23 UTC) #4
Nice addition. LGTM.

Powered by Google App Engine
This is Rietveld 408576698