Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Unified Diff: chrome/test/data/extensions/api_test/cross_origin_xhr/no_file_access/test.js

Issue 10534054: Improve extension api tests: run all tests, even if one fails (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix some tests Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/api_test/cross_origin_xhr/no_file_access/test.js
diff --git a/chrome/test/data/extensions/api_test/cross_origin_xhr/no_file_access/test.js b/chrome/test/data/extensions/api_test/cross_origin_xhr/no_file_access/test.js
index 02ccaab54985940d96e18bda56d5236f3634d895..a4c3c8e50148405683a9216bbeaa26029faac7c2 100644
--- a/chrome/test/data/extensions/api_test/cross_origin_xhr/no_file_access/test.js
+++ b/chrome/test/data/extensions/api_test/cross_origin_xhr/no_file_access/test.js
@@ -16,10 +16,14 @@ chrome.test.getConfig(function(config) {
}
req.onerror = function() {
chrome.test.assertEq(0, req.status);
- chrome.test.runNextTest();
+ chrome.test.succeed();
}
- req.send(null);
+ try {
+ req.send(null);
+ chrome.test.fail('expected an error to be thrown');
+ } catch (e) {
+ };
}
]);
});

Powered by Google App Engine
This is Rietveld 408576698