Issue 10533143: Revert 142048 - Move thread checking from autofill_country.cc to browser_process_impl.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10533143: Revert 142048 - Move thread checking from autofill_country.cc to browser_process_impl.cc (Closed)

Created:
8 years, 6 months ago by mrossetti

Modified:
8 years, 6 months ago

Reviewers:
Xianzhu

CC:
chromium-reviews, dhollowa+watch_chromium.org, Ilya Sherman, dyu1

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 142048 - Move thread checking from autofill_country.cc to browser_process_impl.cc DCHECK(CalledOnValidThread()) is better than BrowserThread::CurrentlyOn(...) because it automatically supports unit test without requiring setting up specific threads. BUG=132643 TEST=Run Autofill tests in debug build Review URL: https://chromiumcodereview.appspot.com/10545169 TBR=wangxianzhu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=142066

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -8 lines)			Patch
M	chrome/browser/autofill/address_unittest.cc	View	5 chunks	+18 lines, -5 lines	0 comments	Download
M	chrome/browser/autofill/autofill_country.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)