Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 10533108: Make calls to any extension action (page/browserAction) API not kill the (Closed)

Created:
8 years, 6 months ago by not at google - send to devlin
Modified:
8 years, 6 months ago
Reviewers:
Matt Perry
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org, benwells, koz (OOO until 15th September)
Visibility:
Public.

Description

Make calls to any extension action (page/browserAction) API not kill the extension if it doesn't have an action specified. Just show an error. BUG=130092 TEST=Get an extension with a background page but no page/browserAction. Enter "chrome.browserAction.getTitle({}, function(){})". Should show error not kill the extension. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141734

Patch Set 1 #

Patch Set 2 : add todo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/extensions/api/extension_action/extension_actions_api.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
not at google - send to devlin
Matt wins extension roulette.
8 years, 6 months ago (2012-06-12 14:35:18 UTC) #1
Matt Perry
Ideally the browserAction namespace would not be defined if the extension has no browser action. ...
8 years, 6 months ago (2012-06-12 19:01:19 UTC) #2
not at google - send to devlin
Yeah, I would like to do that at some point. There are a few other ...
8 years, 6 months ago (2012-06-12 19:25:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/10533108/5001
8 years, 6 months ago (2012-06-12 19:29:18 UTC) #4
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 20:57:59 UTC) #5
Change committed as 141734

Powered by Google App Engine
This is Rietveld 408576698