Make calls to any extension action (page/browserAction) API not kill the

chrome/browser/extensions/api/extension_action/extension_actions_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/extension_action/extension_actions_api.h"
 
 #include <string>
 
 #include "base/string_number_conversions.h"
 #include "base/values.h"
@@ skipping 28 matching lines @@
       extension_action_(NULL) {
 }
 
 ExtensionActionFunction::~ExtensionActionFunction() {
 }
 
 bool ExtensionActionFunction::RunImpl() {
   extension_action_ = GetExtension()->browser_action();
   if (!extension_action_)
     extension_action_ = GetExtension()->page_action();
-  EXTENSION_FUNCTION_VALIDATE(extension_action_);
+  if (!extension_action_) {
+    // TODO(kalman): ideally the browserAction/pageAction APIs wouldn't event
+    // exist for extensions that don't have one declared. This should come as
+    // part of the Feature system.
+    error_ = kNoExtensionActionError;
+    return false;
+  }
 
   // There may or may not be details (depends on the function).
   // The tabId might appear in details (if it exists) or as the first
   // argument besides the action type (depends on the function).
   {
     base::Value* first_arg = NULL;
     EXTENSION_FUNCTION_VALIDATE(args_->Get(0, &first_arg));
 
     switch (first_arg->GetType()) {
       case Value::TYPE_INTEGER:
@@ skipping 224 matching lines @@
 bool ExtensionActionGetBadgeBackgroundColorFunction::RunExtensionAction() {
   ListValue* list = new ListValue();
   SkColor color = extension_action_->GetBadgeBackgroundColor(tab_id_);
   list->Append(Value::CreateIntegerValue(SkColorGetR(color)));
   list->Append(Value::CreateIntegerValue(SkColorGetG(color)));
   list->Append(Value::CreateIntegerValue(SkColorGetB(color)));
   list->Append(Value::CreateIntegerValue(SkColorGetA(color)));
   result_.reset(list);
   return true;
 }