Issue 10533093: Implement WebStorageArea::containsItem(key) in chrome and drt/test_shell.

Issue 10533093: Implement WebStorageArea::containsItem(key) in chrome and drt/test_shell. (Closed)

Created:
8 years, 6 months ago by michaeln

Modified:
3 years, 8 months ago

Reviewers:
ericu, michaeln1

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, pam+watch_chromium.org, jochen+watch-content_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Implement WebStorageArea::containsItem(key) in chrome and drt/test_shell.

Patch Set 3 : #

Total comments: 1

Created: 8 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -6 lines)			Patch
M	content/renderer/dom_storage/webstoragearea_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/dom_storage/webstoragearea_impl.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/dom_storage/dom_storage_cached_area.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/dom_storage/dom_storage_cached_area.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	webkit/dom_storage/dom_storage_map.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/dom_storage/dom_storage_map.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/tools/test_shell/simple_dom_storage_system.cc	View	1 2	2 chunks	+11 lines, -6 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

jochen (gone - plz use gerrit)

https://chromiumcodereview.appspot.com/10533093/diff/12001/webkit/tools/test_shell/simple_dom_storage_system.cc File webkit/tools/test_shell/simple_dom_storage_system.cc (left): https://chromiumcodereview.appspot.com/10533093/diff/12001/webkit/tools/test_shell/simple_dom_storage_system.cc#oldcode57 webkit/tools/test_shell/simple_dom_storage_system.cc:57: virtual unsigned length() OVERRIDE; just wondering, why did you ...

8 years, 6 months ago (2012-06-25 15:21:25 UTC) #3

michaeln1

8 years, 6 months ago (2012-06-25 17:21:43 UTC) #4

To ease 2 sided patch work when removing or adding methods. I think its
fairly common to not use the OVERRIDE keyword when implementing Web*
interfaces in chromium.

On Mon, Jun 25, 2012 at 8:21 AM, <jochen@chromium.org> wrote:

>
> https://chromiumcodereview.**appspot.com/10533093/diff/**
>
12001/webkit/tools/test_shell/**simple_dom_storage_system.cc<https://chromiumcodereview.appspot.com/10533093/diff/12001/webkit/tools/test_shell/simple_dom_storage_system.cc>
> File webkit/tools/test_shell/**simple_dom_storage_system.cc (left):
>
> https://chromiumcodereview.**appspot.com/10533093/diff/**
>
12001/webkit/tools/test_shell/**simple_dom_storage_system.cc#**oldcode57<https://chromiumcodereview.appspot.com/10533093/diff/12001/webkit/tools/test_shell/simple_dom_storage_system.cc#oldcode57>
> webkit/tools/test_shell/**simple_dom_storage_system.cc:**57: virtual
> unsigned length() OVERRIDE;
> just wondering, why did you remove the OVERRIDEs?
>
>
https://chromiumcodereview.**appspot.com/10533093/<https://chromiumcodereview...
>

Expand Messages | Collapse Messages