Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 10533050: Makes method shadowing a getter or setter or vice versa a compile time error. (Closed)

Created:
8 years, 6 months ago by zundel
Modified:
8 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Makes method shadowing a getter or setter or vice versa a compile time error. See issue http://code.google.com/p/dart/issues/detail?id=973 Committed: https://code.google.com/p/dart/source/detail?r=8410

Patch Set 1 : # #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -27 lines) Patch
M compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java View 1 chunk +2 lines, -2 lines 0 comments Download
M compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java View 2 chunks +2 lines, -2 lines 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java View 1 chunk +51 lines, -1 line 0 comments Download
M compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerTest.java View 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-compiler.status View 2 chunks +2 lines, -14 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
zundel
8 years, 6 months ago (2012-06-07 21:51:53 UTC) #1
Brian Wilkerson
LGTM
8 years, 6 months ago (2012-06-07 22:07:10 UTC) #2
scheglov
8 years, 6 months ago (2012-06-08 00:48:55 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698