compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java - Issue 10533050: Makes method shadowing a getter or setter or vice versa a compile time error.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 10533050: Makes method shadowing a getter or setter or vice versa a compile time error. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: # Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/TypeErrorCode.java ('k') | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

index 2b86fbc0ef09086f6ab918784b2e1416f89a5840..4ec32da371a46757528fd9d4f5241e23b9b852a0 100644

--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

@@ -2416,7 +2416,7 @@ public class TypeAnalyzer implements DartCompilationPhase {

checkOverride(node.getName(), field, element);

break;

case METHOD:

- typeError(node, TypeErrorCode.SUPERTYPE_HAS_METHOD, name,

+ typeError(node.getName(), TypeErrorCode.SUPERTYPE_HAS_METHOD, name,

element.getEnclosingElement().getName());

break;

@@ -2444,7 +2444,7 @@ public class TypeAnalyzer implements DartCompilationPhase {

break;

case FIELD:

- typeError(node, TypeErrorCode.SUPERTYPE_HAS_FIELD, element.getName(),

+ typeError(node.getName(), TypeErrorCode.SUPERTYPE_HAS_FIELD, element.getName(),

element.getEnclosingElement().getName());

break;